Skip to content

ARROW-12590: [C++][R] Update copies of Homebrew files to reflect recent updates - #13769

Merged
kou merged 39 commits into
apache:masterfrom
assignUser:update-homebrew
Aug 17, 2022
Merged

kou merged 39 commits into
apache:masterfrom
assignUser:update-homebrew

Conversation

@assignUser

Copy link
Copy Markdown
Member

Building on #12157

@github-actions

github-actions Bot commented Aug 1, 2022

Copy link
Copy Markdown

@assignUser

Copy link
Copy Markdown
Member Author

@jonkeane looks like it works 👍 takes 2x longer on macos-11 though (more features?) maybe we can add (sc)caching later to speed that up.
A sample run: https://github.com/ursacomputing/crossbow/runs/7617843476?check_suite_focus=true

Do I understand configure correctly that tools/autobrew is only used if there is a local formula?

Comment thread r/tools/autobrew Resolved
@assignUser
assignUser marked this pull request as draft August 2, 2022 08:27
@assignUser

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit r-binary-packages homebrew-r-autobrew

@github-actions

github-actions Bot commented Aug 2, 2022

Copy link
Copy Markdown

Revision: 2ca18194303848034dedc24d069dea2d0ff92091

Submitted crossbow builds: ursacomputing/crossbow @ actions-e54e908ed9

Task Status
homebrew-r-autobrew Github Actions
r-binary-packages Github Actions

@assignUser
assignUser marked this pull request as ready for review August 2, 2022 12:45
Comment thread r/tools/autobrew Resolved
@assignUser

Copy link
Copy Markdown
Member Author

@assignUser

Copy link
Copy Markdown
Member Author

I also pulled out 10.13 testing, will open separate JIRA for those.

@assignUser

Copy link
Copy Markdown
Member Author

@nealrichardson upstreaming the changes in dependencies and build flags can happen with the 9.0.0 release PR right?

@assignUser

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit homebrew-r-autobrew r-binary-packages

@github-actions

github-actions Bot commented Aug 3, 2022

Copy link
Copy Markdown

Revision: 27b87156021f0cde8010f66e3b128f360977722f

Submitted crossbow builds: ursacomputing/crossbow @ actions-515f7b9de1

Task Status
homebrew-r-autobrew Github Actions
r-binary-packages Github Actions

@nealrichardson

Copy link
Copy Markdown
Member

@nealrichardson upstreaming the changes in dependencies and build flags can happen with the 9.0.0 release PR right?

Already in progress: autobrew/homebrew-core#114 Please review and make sure we haven't missed anything.

Comment thread LICENSE.txt Resolved
Comment thread dev/tasks/r/github.macos.autobrew.yml Resolved
@assignUser

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit homebrew-r-autobrew

@github-actions

Copy link
Copy Markdown

Revision: 0c7b7dd

Submitted crossbow builds: ursacomputing/crossbow @ actions-06301e563c

Task Status
homebrew-r-autobrew Github Actions

@assignUser

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit homebrew-r-autobrew

@github-actions

Copy link
Copy Markdown

Revision: fbfd86d

Submitted crossbow builds: ursacomputing/crossbow @ actions-9215dbc6a9

Task Status
homebrew-r-autobrew Github Actions

@assignUser

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit homebrew-r-autobrew

@github-actions

Copy link
Copy Markdown

Revision: 1bd4ee2

Submitted crossbow builds: ursacomputing/crossbow @ actions-73c090d310

Task Status
homebrew-r-autobrew Github Actions

@assignUser
assignUser requested a review from kou August 16, 2022 15:15
@assignUser

Copy link
Copy Markdown
Member Author

@neal this should be done now. I will add the 10.13 runners to the nightlies in another PR.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread LICENSE.txt Resolved
@kou

kou commented Aug 17, 2022

Copy link
Copy Markdown
Member

@github-actions crossbow submit homebrew-r-autobrew

@github-actions

Copy link
Copy Markdown

Revision: 197f509

Submitted crossbow builds: ursacomputing/crossbow @ actions-c336cff456

Task Status
homebrew-r-autobrew Github Actions

@kou

kou commented Aug 17, 2022

Copy link
Copy Markdown
Member

@assignUser Hmm. We get a git fetch error:

https://github.com/ursacomputing/crossbow/runs/7870472001?check_suite_focus=true#step:7:572

==> Cloning https://github.com/assignUser/arrow.git
Updating /Users/voltrondata/tmp/apache-arrow--git
git config remote.origin.url https://github.com/assignUser/arrow.git
git config remote.origin.fetch \+refs/heads/master:refs/remotes/origin/master
git fetch origin
==> Checking out revision 197f509f6eb39dd40df1e0ac3a4106769ac5f884
git checkout -f 197f509f6eb39dd40df1e0ac3a4106769ac5f884 --
fatal: reference is not a tree: 197f509f6eb39dd40df1e0ac3a4106769ac5f884
Error: An exception occured within a child process:
  DownloadError: Failed to download resource "apache-arrow"
Failure while executing; `git checkout -f 197f509f6eb39dd40df1e0ac3a4106769ac5f884 --` exited with 128. Here's the output:
fatal: reference is not a tree: 197f509f6eb39dd40df1e0ac3a4106769ac5f884

Could you confirm this?

@assignUser

Copy link
Copy Markdown
Member Author

@kou the issue is with the runner, I need to modify the cleanup script. I'll start another run once I'm done with that.

@assignUser

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit homebrew-r-autobrew

@github-actions

Copy link
Copy Markdown

Revision: 92904b1

Submitted crossbow builds: ursacomputing/crossbow @ actions-6bd568128d

Task Status
homebrew-r-autobrew Github Actions

@kou

kou commented Aug 17, 2022

Copy link
Copy Markdown
Member

It seems to be working.

@kou
kou merged commit 70c6708 into apache:master Aug 17, 2022
@ursabot

ursabot commented Aug 18, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 8474ee5 and contender = 70c6708. 70c6708 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.67% ⬆️0.2%] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.85% ⬆️0.28%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 70c67086 ec2-t3-xlarge-us-east-2
[Failed] 70c67086 test-mac-arm
[Failed] 70c67086 ursa-i9-9960x
[Finished] 70c67086 ursa-thinkcentre-m75q
[Finished] 8474ee5a ec2-t3-xlarge-us-east-2
[Finished] 8474ee5a test-mac-arm
[Failed] 8474ee5a ursa-i9-9960x
[Finished] 8474ee5a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
…nt updates (apache#13769)

Building on apache#12157

Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants