Skip to content

ARROW-17075: [C++] Enforce no trailing slashes on filenames in HDFS#13615

Merged
pitrou merged 1 commit intoapache:masterfrom
wjones127:ARROW-17075-hdfs-fix
Jul 19, 2022
Merged

ARROW-17075: [C++] Enforce no trailing slashes on filenames in HDFS#13615
pitrou merged 1 commit intoapache:masterfrom
wjones127:ARROW-17075-hdfs-fix

Conversation

@wjones127
Copy link
Member

@wjones127 wjones127 commented Jul 15, 2022

Follow up to #13577 / ARROW-17045.

@github-actions
Copy link

github-actions bot commented Jul 15, 2022

https://issues.apache.org/jira/browse/ARROW-17075

@wjones127
Copy link
Member Author

wjones127 commented Jul 15, 2022

@github-actions crossbow submit -g conda-python-hdfs

@github-actions
Copy link

github-actions bot commented Jul 15, 2022 

Invalid group(s) {'conda-python-hdfs'}. Must be one of {'nightly', 'verify-rc-wheels', 'linux-amd64', 'conda', 'linux-arm64', 'example-python', 'fuzz', 'nightly-tests', 'r', 'nightly-release', 'verify-rc-source', 'verify-rc-source-macos', 'cpp', 'example-cpp', 'conan', 'c-glib', 'linux', 'nightly-packaging', 'test', 'verify-rc-jars', 'integration', 'verify-rc-source-linux', 'homebrew', 'ruby', 'verify-rc', 'python', 'vcpkg', 'example', 'verify-rc-binaries', 'wheel', 'packaging'}
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2674102365

@wjones127
Copy link
Member Author

wjones127 commented Jul 15, 2022

@github-actions crossbow submit -g conda-python-hdfs

@wjones127
Copy link
Member Author

wjones127 commented Jul 15, 2022

@github-actions crossbow submit conda-python-hdfs

@github-actions
Copy link

github-actions bot commented Jul 15, 2022 

Invalid group(s) {'conda-python-hdfs'}. Must be one of {'example', 'fuzz', 'verify-rc-wheels', 'verify-rc-source-linux', 'vcpkg', 'linux-amd64', 'homebrew', 'nightly', 'verify-rc-source', 'conan', 'verify-rc-source-macos', 'nightly-packaging', 'example-cpp', 'wheel', 'linux', 'linux-arm64', 'python', 'test', 'ruby', 'verify-rc-jars', 'c-glib', 'packaging', 'example-python', 'nightly-tests', 'verify-rc', 'verify-rc-binaries', 'conda', 'nightly-release', 'integration', 'cpp', 'r'}
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2674154749

@github-actions
Copy link

github-actions bot commented Jul 15, 2022 

Unable to match any tasks for `conda-python-hdfs`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2674168121

@wjones127
Copy link
Member Author

wjones127 commented Jul 15, 2022

@github-actions crossbow submit hdfs

@github-actions
Copy link

github-actions bot commented Jul 15, 2022 

Unable to match any tasks for `_hdfs_`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2674191177

@wjones127
Copy link
Member Author

wjones127 commented Jul 15, 2022

@github-actions crossbow submit hdfs

@github-actions
Copy link

github-actions bot commented Jul 15, 2022 

Unable to match any tasks for `*_hdfs_*`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2674196411

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jul 15, 2022

@github-actions crossbow submit hdfs

@github-actions
Copy link

github-actions bot commented Jul 15, 2022

Revision: 0325cc9

Submitted crossbow builds: ursacomputing/crossbow @ actions-783439d153

Task Status
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jul 15, 2022

@wjones127 the syntax and how it gets displayed by github is a bit confusing, I used *hdfs* (as a glob search pattern), although this "looks" the same as what you typed

@wjones127
Copy link
Member Author

wjones127 commented Jul 15, 2022

@wjones127 the syntax and how it gets displayed by github is a bit confusing, I used hdfs (as a glob search pattern), although this "looks" the same as what you typed

Thanks! I couldn't remember how it works, and GitHub's "quote reply" feature was misleading me to think it was underscores.

@wjones127 wjones127 marked this pull request as ready for review July 15, 2022 14:27
@wjones127
Copy link
Member Author

wjones127 commented Jul 15, 2022

The tests failures are unrelated. The scanner failure test looks to be: https://issues.apache.org/jira/browse/ARROW-17087

pitrou
pitrou approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks. Will wait for AppVeyor build.

@pitrou pitrou merged commit 1cbfed0 into apache:master Jul 19, 2022
@ursabot
Copy link

ursabot commented Jul 19, 2022

Benchmark runs are scheduled for baseline = 13e9e8b and contender = 1cbfed0. 1cbfed0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️1.79%] ec2-t3-xlarge-us-east-2
[Failed ⬇️2.33% ⬆️0.07%] test-mac-arm
[Failed ⬇️0.32% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.29% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] 1cbfed04 ec2-t3-xlarge-us-east-2
[Failed] 1cbfed04 test-mac-arm
[Failed] 1cbfed04 ursa-i9-9960x
[Finished] 1cbfed04 ursa-thinkcentre-m75q
[Failed] 13e9e8bd ec2-t3-xlarge-us-east-2
[Failed] 13e9e8bd test-mac-arm
[Failed] 13e9e8bd ursa-i9-9960x
[Finished] 13e9e8bd ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wjones127 @jorisvandenbossche @ursabot @pitrou