ARROW-1841: [JS] Update text-encoding-utf-8 and tslib for node ESModules support#1338
Closed
trxcllnt wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-1841: [JS] Update text-encoding-utf-8 and tslib for node ESModules support#1338trxcllnt wants to merge 2 commits intoapache:masterfrom
trxcllnt wants to merge 2 commits intoapache:masterfrom
Conversation
4bd2a97 to
7211039
Compare
1e79d21 to
ec9aebd
Compare
ec9aebd to
fbecde5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
text-encoding-utf-8dependency to version 1.0.2, which now supports ESModules in node >= v8.6.0 via the--experimental-modulesflag.We currently support ESModules in node in the main
apache-arrowpackage, but need our dependencies to also expose ESModule forms as well. I have also issued a PR to flatbuffers to add ESModules support, and are using a temporary fork of flatbuffers in my github until that PR is merged.This PR enables the following workflow: