Repository navigation
ARROW-16754: [Java] StructVector's child vectors get unexpectedly reordered after adding duplicated fields - #13321
Conversation
0618667 to
7258fd1
Compare
…duplicated fields
|
@lidavidm @davisusanibar Would one of you want to review this? |
| // in the struct vector | ||
| initFields.add(Field.nullable("varchar1", MinorType.VARCHAR.getType())); | ||
| initFields.add(Field.nullable("varchar2", MinorType.VARCHAR.getType())); | ||
| initFields.add(Field.nullable("varchar3", MinorType.VARCHAR.getType())); |
There was a problem hiding this comment.
Should we also test a duplicated field name with a different type?
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
LGTM overall, with same coment as Antoine.
Should we also test the behavior with VectorSchemaRoot and unions? Presumably the same problem applied to them too.
|
CC @davisusanibar if you'd like to carry this over the finish line |
aa8c721 to
396b46b
Compare
|
Benchmark runs are scheduled for baseline = b11bc50 and contender = 8c6d326. 8c6d326 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
…rdered after adding duplicated fields (apache#13321) Authored-by: Hongze Zhang <[email protected]> Signed-off-by: David Li <[email protected]>
…rdered after adding duplicated fields (apache#13321) Authored-by: Hongze Zhang <[email protected]> Signed-off-by: David Li <[email protected]>
No description provided.