ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo#13241
ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo#13241nealrichardson merged 4 commits intoapache:masterfrom
Conversation
|
|
|
|
|
This should be merged once the upload to nightlies.apache.org is tested and working as expected. |
|
After #13464 I think all you'll need here is the URL change. |
Yep waiting for that to merge to update this :) |
|
Merged now! |
assignUser
force-pushed
the
ARROW-16405-upd-dev-repo
branch
from
c525baa to
9b03bc6
Compare
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
Looks good, just some minor suggestions
|
|
||
| These are used automatically on many Linux distributions (x86_64 architecture only), | ||
| according to the [allowlist](https://github.com/apache/arrow/blob/master/r/tools/nixlibs-allowlist.txt). | ||
| If your distribution isn't in the list, you can opt-in by setting the `NOT_CRAN` |
There was a problem hiding this comment.
Could also note here that we welcome PRs to add distros to the allowlist. Although I'm nervous about calling too much attention to this feature in the package itself.
There was a problem hiding this comment.
Yeah same here, that's why I just reused what you had already added in the other vignette, even thought about just not mentioning it xD We can always change it prior to CRAN submission...
Co-authored-by: Neal Richardson <[email protected]>
|
Thanks @nealrichardson for the review! But that line hasn't been touched in 2 years (and you remove the badges prior to submission iirc?). |
|
Yeah I usually remember to remove badges prior to submission (having been bitten by their flakiness in the past) |
2 participants
merge after #13149