ARROW-16638: [Go][Parquet] Fix boolean column skip#13221
ARROW-16638: [Go][Parquet] Fix boolean column skip#13221mdepero wants to merge 3 commits intoapache:masterfrom mdepero:go-boolskip
Conversation
|
|
| // buf is large enough to hold values, but not to hold def and rep lvls; use nil for them | ||
| vals, _, err := cr.ReadBatch(batch, | ||
| *(*[]bool)(unsafe.Pointer(&buf)), | ||
| arrow.Int16Traits.CastFromBytes(buf), | ||
| arrow.Int16Traits.CastFromBytes(buf)) | ||
| nil, | ||
| nil) |
There was a problem hiding this comment.
Please update the corresponding .tmpl file so that future calls to go generate don't clobber this. Otherwise this LGTM
|
Thanks @mdepero! |
|
Benchmark runs are scheduled for baseline = 7adda73 and contender = 5994fd8. 5994fd8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
3 participants
Uses
nilfordefLvlsandrepLvlswhen skipping boolean values, since the scratch buffer allocated for n boolean values when skipping is not large enough to hold n def and rep levels, resulting in an out of bounds panic when skipping too many rows.