Skip to content

ARROW-16296: [GLib] Add missing casts for GArrowRoundMode#12971

Closed
kou wants to merge 1 commit intoapache:masterfrom
kou:glib-compute-round-options-missing-cast
Closed

ARROW-16296: [GLib] Add missing casts for GArrowRoundMode#12971
kou wants to merge 1 commit intoapache:masterfrom
kou:glib-compute-round-options-missing-cast

Conversation

@kou
Copy link
Member

@kou kou commented Apr 23, 2022

This fixes the following warning:

GLib-GObject-WARNING **: value "((GArrowRoundMode) -765521144)"
of type 'GArrowRoundMode' is invalid or out of range for property
'mode' of type 'GArrowRoundMode'

This fixes the following warning:

    GLib-GObject-WARNING **: value "((GArrowRoundMode) -765521144)"
    of type 'GArrowRoundMode' is invalid or out of range for property
    'mode' of type 'GArrowRoundMode'
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou
Copy link
Member Author

kou commented Apr 23, 2022

+1

@kou kou closed this in dc2e02a Apr 23, 2022
@kou kou deleted the glib-compute-round-options-missing-cast branch April 23, 2022 02:31
@ursabot
Copy link

ursabot commented Apr 28, 2022

Benchmark runs are scheduled for baseline = ebc0be2 and contender = dc2e02a. dc2e02a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed ⬇️8.21% ⬆️2.5%] ursa-i9-9960x
[Finished ⬇️0.5% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/605| dc2e02a4 ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/593| dc2e02a4 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/592| dc2e02a4 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/603| dc2e02a4 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/604| ebc0be21 ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/592| ebc0be21 test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/591| ebc0be21 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/602| ebc0be21 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Apr 28, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants