ARROW-16293: [CI][GLib] Make tests stable#12964
Closed
kou wants to merge 4 commits intoapache:masterfrom
Closed
Conversation
1. Increase timeout to 60 from 40 for macOS job because 40 is short to build without ccache cache. 2. Don't build C++ utilities (ARROW_BUILD_UTILITIES=OFF) because they aren't used. 3. Omit a test for gparquet_row_group_metadata_equal() because it seems that parquet::RowGroupMetaData::Equals() is unstable. We can look into this later and fix this. 4. (Optional) Suppress the following warning on Windows by removing temporary files explicitly: warning: Exception in finalizer #<Tempfile::Remover:0x00000277338b1ad0 @pid=6736, @tmpfile=#<File:D:/a/_temp/data20220422-6736-dotfsz.parquet (closed)>> C:/hostedtoolcache/windows/Ruby/3.1.2/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20220422-6736-dotfsz.parquet (Errno::EACCES)
|
|
It seems that finalizer isn't removed with Tempfile#close! on Windows...
We should do this in separated pull request.
Member
Author
|
+1 |
|
['Python', 'R'] benchmarks have high level of regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to build without ccache cache.
they aren't used.
it seems that parquet::RowGroupMetaData::Equals() is unstable.
We can look into this later and fix this.