Skip to content

ARROW-15312: [R][C++] filtering a Parquet dataset with is.na() misses some rows#12950

Closed
jonkeane wants to merge 3 commits intoapache:masterfrom
jonkeane:ARROW-15312
Closed

ARROW-15312: [R][C++] filtering a Parquet dataset with is.na() misses some rows#12950
jonkeane wants to merge 3 commits intoapache:masterfrom
jonkeane:ARROW-15312

Conversation

@jonkeane
Copy link
Member

The real fix was in #12891 (ARROW-12659) but this adds integration tests from the ticket to confirm this works in R + we don't run into this in the future

@github-actions
Copy link

@ursabot
Copy link

ursabot commented Apr 25, 2022

Benchmark runs are scheduled for baseline = a6296cb and contender = 285667c. 285667c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed ⬇️4.14% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.84% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/584| 285667cc ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/572| 285667cc test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/570| 285667cc ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/582| 285667cc ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/583| a6296cb5 ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/571| a6296cb5 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/569| a6296cb5 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/581| a6296cb5 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants