Skip to content

ARROW-16264: [C++][CI] Valgrind timeout in arrow-compute-hash-join-node-test#12944

Closed
westonpace wants to merge 3 commits intoapache:masterfrom
westonpace:bugfix/ARROW-16264--valgrind-timeout-hash-join-node-test
Closed

ARROW-16264: [C++][CI] Valgrind timeout in arrow-compute-hash-join-node-test#12944
westonpace wants to merge 3 commits intoapache:masterfrom
westonpace:bugfix/ARROW-16264--valgrind-timeout-hash-join-node-test

Conversation

@westonpace
Copy link
Member

No description provided.

@westonpace
Copy link
Member Author

@github-actions crossbow submit test-conda-cpp-valgrind

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@github-actions
Copy link

Revision: ae3daabd4fd73f5203ad4b3a4ab246444ba0ba1e

Submitted crossbow builds: ursacomputing/crossbow @ actions-1895

Task Status
test-conda-cpp-valgrind Azure

@westonpace westonpace force-pushed the bugfix/ARROW-16264--valgrind-timeout-hash-join-node-test branch from ae3daab to a281ad8 Compare April 21, 2022 17:37
@westonpace westonpace marked this pull request as draft April 21, 2022 17:38
@westonpace
Copy link
Member Author

@github-actions crossbow submit test-conda-cpp-valgrind

@westonpace
Copy link
Member Author

I rebased this on top of the tpc-h generator cleanup since those valgrind failures were blocking the test of this feature. I converted this to draft as we should merge the other fix first and then I'll convert it back to ready-for-review.

@github-actions
Copy link

Revision: a281ad8542fb35aa418bc2eefc8f63a2ef64b8cb

Submitted crossbow builds: ursacomputing/crossbow @ actions-1900

Task Status
test-conda-cpp-valgrind Azure

@westonpace westonpace force-pushed the bugfix/ARROW-16264--valgrind-timeout-hash-join-node-test branch 2 times, most recently from ab8b748 to 31b6818 Compare April 22, 2022 04:09
@westonpace westonpace marked this pull request as ready for review April 22, 2022 04:11
@westonpace
Copy link
Member Author

CC @michalursa Valgrind started timing out on the hash-join-node-test. The root cause for the newly emerged failure may have been the addition of the bloom filter tests or it may have been that I accidentally made the hash join node tests slow. Either way, I think it's probably fine to shorten the size of inputs we use when testing via valgrind.

@westonpace westonpace force-pushed the bugfix/ARROW-16264--valgrind-timeout-hash-join-node-test branch from 31b6818 to 3080dab Compare April 22, 2022 20:58
@westonpace
Copy link
Member Author

@github-actions crossbow submit test-conda-cpp-valgrind

@github-actions
Copy link

Revision: 3080dab

Submitted crossbow builds: ursacomputing/crossbow @ actions-1920

Task Status
test-conda-cpp-valgrind Azure

@westonpace
Copy link
Member Author

I'm going to move forward with this to unblock valgrind. If we decide later we want to extend the test set on valgrind we can fix that in a follow-up.

@ursabot
Copy link

ursabot commented Apr 27, 2022

Benchmark runs are scheduled for baseline = ea296cd and contender = 6c1a160. 6c1a160 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.17% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/602| 6c1a160c ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/590| 6c1a160c test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/589| 6c1a160c ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/600| 6c1a160c ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/601| ea296cd6 ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/589| ea296cd6 test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/588| ea296cd6 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/599| ea296cd6 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Apr 27, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants