ARROW-15015: [R] Test / CI flag for ensuring all tests are run?#12940
Closed
assignUser wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-15015: [R] Test / CI flag for ensuring all tests are run?#12940assignUser wants to merge 3 commits intoapache:masterfrom
assignUser wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
|
Should be merge after #12946 ✔️ |
jonkeane
requested changes
Apr 21, 2022
Member
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
This is looking great, a few comments. Thanks!
assignUser
force-pushed
the
ARROW-15015-all-tests
branch
from
caa5614 to
6b8339e
Compare
jonkeane
approved these changes
Apr 22, 2022
Member
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
This looks good — let's rebase + run this when that other ticket you mention has merged and make sure it passes — so long as it does, I'm ➕ to merge
Member
Author
|
It is merged an I rebased, I think the failures are due to the git cve or something? I'll check. |
kszucs
force-pushed
the
ARROW-15015-all-tests
branch
from
6b8339e to
5963098
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jonkeane there are still a bunch of skips but the once relying on the "helper-skip" functions should all be forced to run now.