Skip to content

ARROW-16176: [Release][C#] Use .NET 6.0 on Ubuntu 22.04#12870

Closed
kou wants to merge 3 commits intoapache:masterfrom
kou:release-ubuntu-22.04-csharp
Closed

ARROW-16176: [Release][C#] Use .NET 6.0 on Ubuntu 22.04#12870
kou wants to merge 3 commits intoapache:masterfrom
kou:release-ubuntu-22.04-csharp

Conversation

@kou
Copy link
Member

@kou kou commented Apr 12, 2022

Ubuntu 22.04 ships OpenSSL 3 and .NET 5.0 or earlier doesn't support
OpenSSL 3 yet.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou
Copy link
Member Author

kou commented Apr 12, 2022

@github-actions crossbow submit viery-rc-source-csharp-*

@github-actions
Copy link

Unable to match any tasks for `viery-rc-source-csharp-*`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2158165874```

@kou
Copy link
Member Author

kou commented Apr 12, 2022

@github-actions crossbow submit verify-rc-source-csharp-*

@github-actions
Copy link

Revision: 2ed44c0c7944561b6d52c3a6804207f3722a99c6

Submitted crossbow builds: ursacomputing/crossbow @ actions-1839

Task Status
verify-rc-source-csharp-linux-almalinux-8-amd64 Github Actions
verify-rc-source-csharp-linux-conda-latest-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-csharp-macos-amd64 Github Actions
verify-rc-source-csharp-macos-arm64 Github Actions

@kou kou force-pushed the release-ubuntu-22.04-csharp branch from 2ed44c0 to 285c47c Compare April 12, 2022 23:54
@kou
Copy link
Member Author

kou commented Apr 12, 2022

@github-actions crossbow submit verify-rc-source-csharp-*

@github-actions
Copy link

Revision: 285c47c5b4654f603d92842140f9add1c202c549

Submitted crossbow builds: ursacomputing/crossbow @ actions-1840

Task Status
verify-rc-source-csharp-linux-almalinux-8-amd64 Github Actions
verify-rc-source-csharp-linux-conda-latest-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-csharp-macos-amd64 Github Actions
verify-rc-source-csharp-macos-arm64 Github Actions

@kou
Copy link
Member Author

kou commented Apr 13, 2022

@eerhardt It seems that our tests can't be ran with .NET 6.0:

https://github.com/ursacomputing/crossbow/runs/5999340698?check_suite_focus=true

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Testhost process exited with error: It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '3.1.0' (x64) was not found.
  - The following frameworks were found:
      6.0.4 at [/tmp/arrow-HEAD.6doHP/csharp/bin/shared/Microsoft.NETCore.App]
You can resolve the problem by installing the specified framework and/or SDK.
The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=3.1.0&arch=x64&rid=ubuntu.22.04-x64
. Please check the diagnostic logs for more information.

Test Run Aborted.
  Apache.Arrow.Flight -> /arrow/csharp/artifacts/Apache.Arrow.Flight/Debug/netstandard2.1/Apache.Arrow.Flight.dll
  Apache.Arrow.Flight -> /arrow/csharp/artifacts/Apache.Arrow.Flight/Debug/netstandard2.0/Apache.Arrow.Flight.dll
  Apache.Arrow.Flight.AspNetCore -> /arrow/csharp/artifacts/Apache.Arrow.Flight.AspNetCore/Debug/netcoreapp3.1/Apache.Arrow.Flight.AspNetCore.dll
  Apache.Arrow.Flight.TestWeb -> /arrow/csharp/artifacts/Apache.Arrow.Flight.TestWeb/Debug/netcoreapp3.1/Apache.Arrow.Flight.TestWeb.dll
  Apache.Arrow.Flight.Tests -> /arrow/csharp/artifacts/Apache.Arrow.Flight.Tests/Debug/netcoreapp3.1/Apache.Arrow.Flight.Tests.dll
Test run for /arrow/csharp/artifacts/Apache.Arrow.Flight.Tests/Debug/netcoreapp3.1/Apache.Arrow.Flight.Tests.dll (.NETCoreApp,Version=v3.1)
Microsoft (R) Test Execution Command Line Tool Version 17.0.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Testhost process exited with error: It was not possible to find any compatible framework version
The framework 'Microsoft.AspNetCore.App', version '3.1.0' (x64) was not found.
  - The following frameworks were found:
      6.0.4 at [/tmp/arrow-HEAD.6doHP/csharp/bin/shared/Microsoft.AspNetCore.App]
You can resolve the problem by installing the specified framework and/or SDK.
The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.AspNetCore.App&framework_version=3.1.0&arch=x64&rid=ubuntu.22.04-x64
. Please check the diagnostic logs for more information.

Should we support .NET 6.0? Or should we disable verification with .NET 6.0?

@eerhardt
Copy link
Contributor

eerhardt commented Apr 23, 2022

Sorry for the delay.

Since 2.1 is EOL, I think it makes sense to update our projects to supported versions.

The issue here is that the tests want to run against .NET Core 3.1 runtime, but the machine only has 6.0 installed. To fix this we can either:

  • also install the 3.1 runtime
  • upgrade our tests to target 6.0 instead of 3.1

At this point I think it would make sense to take the latter approach and just target 6.0 everywhere.

Do you want me to push changes to this PR to fix this? Or do you want me to send a separate PR?

@kou
Copy link
Member Author

kou commented Apr 23, 2022

Do you want me to push changes to this PR to fix this? Or do you want me to send a separate PR?

The former is better but you can choose the latter if you have a trouble.

@eerhardt
Copy link
Contributor

@github-actions crossbow submit verify-rc-source-csharp-*

@github-actions
Copy link

Revision: 2c8c80650fc518644f1565db9cf9085baf2d93b1

Submitted crossbow builds: ursacomputing/crossbow @ actions-1933

Task Status
verify-rc-source-csharp-linux-almalinux-8-amd64 Github Actions
verify-rc-source-csharp-linux-conda-latest-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-csharp-macos-amd64 Github Actions
verify-rc-source-csharp-macos-arm64 Github Actions

kou and others added 2 commits April 24, 2022 18:18
Ubuntu 22.04 ships OpenSSL 3 and .NET 5.0 or earlier doesn't support
OpenSSL 3 yet.
- Update the .NET SDK from 3.1 to 6.0
- Apache.Arrow.csproj moves targets from 2.1 to 3.1 since 2.1 is EOL.
- All tests and exe moves to net6.0.
@kszucs kszucs force-pushed the release-ubuntu-22.04-csharp branch from 2c8c806 to 0c6abeb Compare April 24, 2022 16:18
@kszucs
Copy link
Member

kszucs commented Apr 24, 2022

@github-actions crossbow submit verify-rc-source-csharp-*

@github-actions
Copy link

Revision: 0c6abeb

Submitted crossbow builds: ursacomputing/crossbow @ actions-1935

Task Status
verify-rc-source-csharp-linux-almalinux-8-amd64 Github Actions
verify-rc-source-csharp-linux-conda-latest-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-csharp-macos-amd64 Github Actions
verify-rc-source-csharp-macos-arm64 Github Actions

@kszucs
Copy link
Member

kszucs commented Apr 24, 2022

@github-actions crossbow submit verify-rc-source-csharp-*

@github-actions
Copy link

Revision: 135f66c

Submitted crossbow builds: ursacomputing/crossbow @ actions-1936

Task Status
verify-rc-source-csharp-linux-almalinux-8-amd64 Github Actions
verify-rc-source-csharp-linux-conda-latest-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-csharp-macos-amd64 Github Actions
verify-rc-source-csharp-macos-arm64 Github Actions

Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eerhardt and @kou!

@kszucs kszucs closed this in f275f50 Apr 24, 2022
@kou kou deleted the release-ubuntu-22.04-csharp branch April 24, 2022 19:57
@kou
Copy link
Member Author

kou commented Apr 24, 2022

Thanks @eerhardt !

@ursabot
Copy link

ursabot commented Apr 29, 2022

Benchmark runs are scheduled for baseline = f6c99d5 and contender = f275f50. f275f50 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] f275f507 ec2-t3-xlarge-us-east-2
[Failed] f275f507 test-mac-arm
[Finished] f275f507 ursa-i9-9960x
[Finished] f275f507 ursa-thinkcentre-m75q
[Finished] f6c99d51 ec2-t3-xlarge-us-east-2
[Failed] f6c99d51 test-mac-arm
[Finished] f6c99d51 ursa-i9-9960x
[Finished] f6c99d51 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants