Skip to content

ARROW-15857: [R] rhub/fedora-clang-devel fails to install 'sass' (rmarkdown dependency) - #12734

Closed
paleolimbot wants to merge 1 commit into
apache:masterfrom
paleolimbot:r-fedora-clang
Closed

ARROW-15857: [R] rhub/fedora-clang-devel fails to install 'sass' (rmarkdown dependency)#12734
paleolimbot wants to merge 1 commit into
apache:masterfrom
paleolimbot:r-fedora-clang

Conversation

@paleolimbot

@paleolimbot paleolimbot commented Mar 28, 2022

Copy link
Copy Markdown
Member

Fixes the nightly build failures for rhub/fedora-clang-devel (github-test-r-linux-as-cran). (For example, https://github.com/ursacomputing/crossbow/runs/5713825093?check_suite_focus=true#step:5:3011). The gist of the problem is that -stdlib=libc++ is in CXXFLAGS but not LDFLAGS.

@jonkeane I have no idea how to test to make sure this works!

@nealrichardson

nealrichardson commented Mar 28, 2022

Copy link
Copy Markdown
Member

@jonkeane I have no idea how to test to make sure this works!

You should be able to run this docker test locally, Jon can show you how

We may want to try upstreaming these fedora-clang-devel changes to r-hub again

@jonkeane

jonkeane commented Mar 28, 2022

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-r-linux-as-cran

This will run the crossbow job (though that will likely be delayed as awe wait for github actions to catch up today)

@github-actions

github-actions Bot commented Mar 28, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-15857

@github-actions

github-actions Bot commented Mar 28, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@jonkeane

jonkeane commented Mar 28, 2022

Copy link
Copy Markdown
Member

And locally, you can (inside of the arrow repo):

R_ORG=rhub R_IMAGE=fedora-clang-devel R_tag=latest ARROW_R_DEV=FALSE docker-compose run -e ARROW_SOURCE_HOME='' r

I found the env vars + flags from:

arrow/dev/tasks/r/github.linux.cran.yml

Lines 37 to 48 in d327f69

R_ORG: "rhub"
R_IMAGE: {{ MATRIX }}
R_TAG: "latest"
ARROW_R_DEV: "FALSE"
steps:
{{ macros.github_checkout_arrow()|indent }}
{{ macros.github_install_archery()|indent }}
- name: Docker Run
shell: bash
# setting ARROW_SOURCE_HOME='' here ensures that we use the cpp source copied into tools/
run: archery docker run -e ARROW_SOURCE_HOME='' r

That uses the archery docker runner on the last line, which is ~ the same as docker-compose run for the r service. For others (like ubuntu-r) the archery docker setup is slightly nicer because it deals with dependent services.

@github-actions

github-actions Bot commented Mar 28, 2022

Copy link
Copy Markdown

Revision: c410f81

Submitted crossbow builds: ursacomputing/crossbow @ actions-1800

Task Status
test-r-linux-as-cran Github Actions

jonkeane
jonkeane approved these changes Mar 28, 2022
View reviewed changes

@jonkeane jonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good. Thanks!

@jonkeane jonkeane closed this in ad7380e Mar 28, 2022
@ursabot

ursabot commented Mar 28, 2022 •
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 6a0770c and contender = ad7380e. ad7380e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.34% ⬆️0.13%] test-mac-arm
[Failed ⬇️1.07% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.34% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

This was referenced Mar 30, 2022
Merged
Merged
@paleolimbot paleolimbot mentioned this pull request Apr 7, 2022
Merged
paleolimbot added a commit that referenced this pull request Aug 24, 2022
@paleolimbot
ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes (
c90d07f 
#12824)

In ARROW-15857 (#12734) we fixed the nightly failures on rhub/fedora-clang-devel by a kludge modifying the default makefile, but also upstreamed the fixes (rstudio/sass#104 and r-hub/rhub-linux-builders#60). These upstreams are now both released, so we can remove the kludge from modification of the docker image.

Lead-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@paleolimbot @zagto
ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes (
9f912cf 
apache#12824)

In ARROW-15857 (apache#12734) we fixed the nightly failures on rhub/fedora-clang-devel by a kludge modifying the default makefile, but also upstreamed the fixes (rstudio/sass#104 and r-hub/rhub-linux-builders#60). These upstreams are now both released, so we can remove the kludge from modification of the docker image.

Lead-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
@paleolimbot
paleolimbot deleted the r-fedora-clang branch December 9, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonkeane jonkeane jonkeane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paleolimbot @nealrichardson @jonkeane @ursabot