Repository navigation
ARROW-15871: [Python] Start raising deprecation warnings for ParquetDataset keywords that won't be supported with the new API - #12585
Closed
jorisvandenbossche wants to merge 3 commits into
Closed
jorisvandenbossche wants to merge 3 commits into
jorisvandenbossche wants to merge 3 commits into
Conversation
Member
Author
|
@github-actions crossbow submit -g integration |
|
Revision: 0001bf47ac4b5916234eae79f689eaa5f10de889 Submitted crossbow builds: ursacomputing/crossbow @ actions-1729
|
pitrou
approved these changes
Mar 10, 2022
Comment on lines
1407
to
1416
Member
There was a problem hiding this comment.
Suggested change
| "Specifying the 'metadata_nthreads' keyword is deprecated as " | |
| "of pyarrow 8.0.0, and the keyword will be removed in a " | |
| "future version", | |
| "Specifying the 'metadata_nthreads' argument is deprecated as " | |
| "of pyarrow 8.0.0, and the keyword will be argument in a " | |
| "future version", |
Member
There was a problem hiding this comment.
(may need reformatting after this change?)
Member
There was a problem hiding this comment.
Here as well, say "argument" not "keyword".
jorisvandenbossche
force-pushed
the
ARROW-15871
branch
from
March 15, 2022 19:24
0001bf4 to
2b5345e
Compare
… it in the non-legacy read_table
Member
|
I forgot about this PR. I rebased and will merge if green. |
Member
|
@github-actions crossbow submit -g integration |
|
Revision: 6ebd216 Submitted crossbow builds: ursacomputing/crossbow @ actions-1805
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added warnings for when passing the
schemaandmetadata_nthreadskeywords.For
schema, also enabled this keyword for the new implementation (passing through theschemakeyword to the datasets API), but so in this case this is about a pyarrow.Schema and not a ParquetSchema that should be passed.