ARROW-14506: [C++] Conda support for google-cloud-cpp#11851
Closed
coryan wants to merge 3 commits intoapache:masterfrom
coryan:ARROW-14506-add-google-cloud-cpp-to-conda-files
Closed
ARROW-14506: [C++] Conda support for google-cloud-cpp#11851coryan wants to merge 3 commits intoapache:masterfrom coryan:ARROW-14506-add-google-cloud-cpp-to-conda-files
coryan wants to merge 3 commits intoapache:masterfrom
coryan:ARROW-14506-add-google-cloud-cpp-to-conda-files
Conversation
This PR adds support for `google-cloud-cpp` to the Conda files. Probably the most difficult change to grok is the change to compile with C++17 when using Conda: - Conda defaults all its builds to C++17, [this bug](conda/conda-build#3375) goes into some detail as to why. - Arrow defaults to C++11 if no `CMAKE_CXX_STANDARD` argument is provided. - Abseil's ABI changes when used from C++11 vs. C++17, see abseil/abseil-cpp#696 - Therefore, one must compile with C++17 to use Abseil in Conda. - And because `google-cloud-cpp` has a direct dependency on Abseil, exposed through the headers, one must use C++17 to use `google-cloud-cpp` too.
kszucs
reviewed
Dec 6, 2021
| -DARROW_FLIGHT=ON \ | ||
| -DARROW_FLIGHT_REQUIRE_TLSCREDENTIALSOPTIONS=ON \ | ||
| -DARROW_GCS=ON \ | ||
| -DARROW_HDFS=ON \ |
Member
There was a problem hiding this comment.
The meta.yml must also contain the google-cloud-cpp host dependency.
Contributor
Author
There was a problem hiding this comment.
Done. I suspect this may break things (see below).
kszucs
reviewed
Dec 6, 2021
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| google-cloud-cpp>=1.34.0 |
Member
There was a problem hiding this comment.
Is google-cloud-cpp only supported on linux?
Contributor
Author
There was a problem hiding this comment.
google-cloud-cpp is supported on Linux, Windows and macOS. The Conda packages only work on Linux and macOS:
conda-forge/google-cloud-cpp-feedstock#76
If needed, I am happy to fix the Conda package first and then resubmit this PR.
Member
There was a problem hiding this comment.
That would certainly simplify this PR. Until that we can use the bundled google-cloud-cpp.
Contributor
Author
|
Closing until the Conda packages are fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
google-cloud-cppto the Conda files.Probably the most difficult change to grok is the change to compile with
C++17 when using Conda:
this bug goes into
some detail as to why.
CMAKE_CXX_STANDARDargument isprovided.
Abseil should install w/ the correct base/options.h abseil/abseil-cpp#696
google-cloud-cpphas a direct dependency on Abseil,exposed through the headers, one must use C++17 to use
google-cloud-cpptoo.