ARROW-1641: [C++] Hide std::mutex from public headers#1165
ARROW-1641: [C++] Hide std::mutex from public headers#1165wesm wants to merge 4 commits intoapache:masterfrom
Conversation
|
Hm, seems I have some more work to do here. I'm not sure about the best strategy for threadsafety by default in the The default option is that I add basic implementations to the classes that are breaking the build currently |
Change-Id: I0bb5695fa1cf7a591f7333bb8c63487212d0d749
…ix deadlocks in ReadableFile Change-Id: I9d09b0daaa6a00562d5ed9e63e704258a3687b58
|
This should be ready to go once the tests pass |
|
hm, there's a test failure, it looks like I borked something with threadsafety. taking another look |
Change-Id: I738a713e0a17cb6c8cdf3c2eaa3191fb39253f06
|
@kou it's possible that this patch introduces threadsafety issues in the GIO wrapper implementations if you use the |
Change-Id: Ie5e1be5e7d4c119fde229c55d88c7aaaf40388cd
|
Thanks for the heads-up. |
|
Waiting for https://ci.appveyor.com/project/wesm/arrow/build/1.0.1269 since I twiddled some symbol visibility stuff |
|
+1 |
This was one part of ARROW-1134 that we can push through. I had to do some refactoring since there was a mutex in one of the base file interfaces. It doesn't appear that this will impact parquet-cpp or other Arrow users