ARROW-1546: [GLib] Support GLib 2.40 again by kou · Pull Request #1106 · apache/arrow

kou · 2017-09-17T11:44:37Z

Ubuntu 14.04 ships GLib 2.40.

wesm · 2017-09-17T17:50:42Z

c_glib/arrow-glib/gobject-type.h

Since GLib is LGPL (which is Category X) I wanted to check that this code did not come from that codebase

GLib's implementation is here: https://git.gnome.org/browse/glib/tree/gobject/gtype.h#n1395

This implementation generates codes based on

arrow/c_glib/arrow-glib/array.h

Lines 28 to 60 in c1492bf

#define GARROW_TYPE_ARRAY \

(garrow_array_get_type())

#define GARROW_ARRAY(obj) \

(G_TYPE_CHECK_INSTANCE_CAST((obj), GARROW_TYPE_ARRAY, GArrowArray))

#define GARROW_ARRAY_CLASS(klass) \

(G_TYPE_CHECK_CLASS_CAST((klass), GARROW_TYPE_ARRAY, GArrowArrayClass))

#define GARROW_IS_ARRAY(obj) \

(G_TYPE_CHECK_INSTANCE_TYPE((obj), GARROW_TYPE_ARRAY))

#define GARROW_IS_ARRAY_CLASS(klass) \

(G_TYPE_CHECK_CLASS_TYPE((klass), GARROW_TYPE_ARRAY))

#define GARROW_ARRAY_GET_CLASS(obj) \

(G_TYPE_INSTANCE_GET_CLASS((obj), GARROW_TYPE_ARRAY, GArrowArrayClass))

typedef struct _GArrowArray GArrowArray;

typedef struct _GArrowArrayClass GArrowArrayClass;

/**

* GArrowArray:

*

* It wraps `arrow::Array`.

*/

struct _GArrowArray

{

/*< private >*/

GObject parent_instance;

};

struct _GArrowArrayClass

{

GObjectClass parent_class;

};

GType garrow_array_get_type (void) G_GNUC_CONST;

Defining macros such as GARROW_ARRAY() by "static inline" function idea is taken from GLib's implementation. Others aren't taken.

It seems that the idea (implementing convenient functions by "static inline" function instead of macro) is a generic C technique. I know that Ruby is also uses the technique such as https://github.com/ruby/ruby/blob/trunk/include/ruby/ruby.h#L307-L320 .

So I think that this code isn't LGPL-ed work.

No problem, thank you. Since this was feature backporting issue I just wanted to check. Reusing implementation ideas is no problem so long as actual lines of Category X code are not being redistributed or otherwise directly ported

Thanks for checking license issue!

wesm · 2017-09-17T18:10:28Z

Can you also rebase on master?

Ubuntu 14.04 ships GLib 2.40.

kou · 2017-09-17T21:56:04Z

Done.
I think that C++ failure https://travis-ci.org/apache/arrow/jobs/276617308 isn't related this change.

wesm

+1

asfgit force-pushed the master branch from 40e72f5 to 59b24ba Compare September 17, 2017 17:46

wesm reviewed Sep 17, 2017

View reviewed changes

[GLib] Support GLib 2.40 again

cbcdf9a

Ubuntu 14.04 ships GLib 2.40.

kou force-pushed the glib-support-glib-2.40-again branch from daadd3f to cbcdf9a Compare September 17, 2017 21:13

wesm approved these changes Sep 17, 2017

View reviewed changes

asfgit closed this in bfe6579 Sep 17, 2017

kou deleted the glib-support-glib-2.40-again branch September 17, 2017 22:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARROW-1546: [GLib] Support GLib 2.40 again#1106

ARROW-1546: [GLib] Support GLib 2.40 again#1106
kou wants to merge 1 commit intoapache:masterfrom
kou:glib-support-glib-2.40-again

kou commented Sep 17, 2017

Uh oh!

wesm Sep 17, 2017

Uh oh!

kou Sep 17, 2017

Uh oh!

wesm Sep 17, 2017

Uh oh!

kou Sep 17, 2017

Uh oh!

wesm commented Sep 17, 2017

Uh oh!

kou commented Sep 17, 2017

Uh oh!

wesm left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	#define GARROW_TYPE_ARRAY \
	(garrow_array_get_type())
	#define GARROW_ARRAY(obj) \
	(G_TYPE_CHECK_INSTANCE_CAST((obj), GARROW_TYPE_ARRAY, GArrowArray))
	#define GARROW_ARRAY_CLASS(klass) \
	(G_TYPE_CHECK_CLASS_CAST((klass), GARROW_TYPE_ARRAY, GArrowArrayClass))
	#define GARROW_IS_ARRAY(obj) \
	(G_TYPE_CHECK_INSTANCE_TYPE((obj), GARROW_TYPE_ARRAY))
	#define GARROW_IS_ARRAY_CLASS(klass) \
	(G_TYPE_CHECK_CLASS_TYPE((klass), GARROW_TYPE_ARRAY))
	#define GARROW_ARRAY_GET_CLASS(obj) \
	(G_TYPE_INSTANCE_GET_CLASS((obj), GARROW_TYPE_ARRAY, GArrowArrayClass))

	typedef struct _GArrowArray GArrowArray;
	typedef struct _GArrowArrayClass GArrowArrayClass;

	/**
	* GArrowArray:
	*
	* It wraps `arrow::Array`.
	*/
	struct _GArrowArray
	{
	/< private >/
	GObject parent_instance;
	};

	struct _GArrowArrayClass
	{
	GObjectClass parent_class;
	};

	GType garrow_array_get_type (void) G_GNUC_CONST;

Conversation

kou commented Sep 17, 2017

Uh oh!

wesm Sep 17, 2017

Choose a reason for hiding this comment

Uh oh!

kou Sep 17, 2017

Choose a reason for hiding this comment

Uh oh!

wesm Sep 17, 2017

Choose a reason for hiding this comment

Uh oh!

kou Sep 17, 2017

Choose a reason for hiding this comment

Uh oh!

wesm commented Sep 17, 2017

Uh oh!

kou commented Sep 17, 2017

Uh oh!

wesm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants