ARROW-1536:[C++] Do not transitively depend on libboost_system#1105
Closed
majetideepak wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-1536:[C++] Do not transitively depend on libboost_system#1105majetideepak wants to merge 3 commits intoapache:masterfrom
majetideepak wants to merge 3 commits intoapache:masterfrom
Conversation
majetideepak
force-pushed
the
ARROW-1536
branch
2 times, most recently
from
b7c4e7b to
bf801cd
Compare
wesm
reviewed
Sep 18, 2017
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
This looks like a fine solution, thank you! I left a couple comments; this may also need a make format
cpp/src/arrow/io/file.cc
Outdated
cpp/src/arrow/io/file.cc
Outdated
Member
There was a problem hiding this comment.
I think it may be simpler to do file_name_ = PlatformFilename{file_name}, then you don't even need the Init method I don't think
Member
|
Can you also rebase? thanks |
majetideepak
force-pushed
the
ARROW-1536
branch
from
bf801cd to
6239925
Compare
majetideepak
force-pushed
the
ARROW-1536
branch
from
6239925 to
9f4ed61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.