ARROW-1464: [GLib] Add "Common build problems" section into the README.md of c_glib by wagavulin · Pull Request #1104 · apache/arrow

wagavulin · 2017-09-16T17:53:12Z

Add some detailed explanation of common build problems especially on macOS because it requires some tweaks.

kou · 2017-09-17T00:22:04Z

c_glib/README.md

You can use console for the case.

kou

Thanks!
I added some comments!

kou · 2017-09-17T00:22:44Z

c_glib/README.md

following -> above?

No. Warning: autoconf-archive 2017.03.21 is already installed, it's just not linked. ... is a warning message of brew install autconf-archive. And Linking /usr/local/Cellar/autoconf-archive/2017.03.21... is an error message of brew link autoconf-archive. So "following" is correct. But I think this paragraph may confusing, so I will rewrite.

kou · 2017-09-17T00:22:52Z

c_glib/README.md

kou · 2017-09-17T00:23:33Z

c_glib/README.md

Please add an empty new line after a section.

kou · 2017-09-17T00:23:59Z

c_glib/README.md

Please use % for prompt. Because we already use % in this file.

kou · 2017-09-17T00:24:19Z

c_glib/README.md

Please add an empty line here.

kou · 2017-09-17T00:26:14Z

c_glib/README.md

./configure PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig

is better because configure keeps the PKG_CONFIG_PATH value with this form.

kou · 2017-09-17T00:26:25Z

c_glib/README.md

kou · 2017-09-17T00:28:09Z

c_glib/README.md

Or we can use --with-arrow-cpp-build-type and --with-arrow-cpp-build-dir configure options.
It's better that description of them are included in this pull request but it's not required.

#1100 and https://issues.apache.org/jira/browse/ARROW-1537 may be useful information for macOS.

Thank you for useful advice. However I think such an advanced setting is not necessary for this "common build failures" section. It assumes that Arrow C++ is installed in accordance with cpp/README.md.

wesm · 2017-09-17T18:11:09Z

This should rebase cleanly in apache/master (I rebased master on the release branch and now pushed)

wesm · 2017-09-18T03:39:21Z

Please also remove the brackets from "[ARROW-1464]:"

Add some detailed explanation of common build problems especially on macOS because it requires some tweaks.

wagavulin

Thank you for your comment. I will try to improve the explanation of brew link issue.

wagavulin · 2017-09-18T09:46:07Z

c_glib/README.md

wagavulin · 2017-09-18T09:46:20Z

c_glib/README.md

wagavulin · 2017-09-18T09:46:37Z

c_glib/README.md

wagavulin · 2017-09-18T10:12:46Z

c_glib/README.md

No. Warning: autoconf-archive 2017.03.21 is already installed, it's just not linked. ... is a warning message of brew install autconf-archive. And Linking /usr/local/Cellar/autoconf-archive/2017.03.21... is an error message of brew link autoconf-archive. So "following" is correct. But I think this paragraph may confusing, so I will rewrite.

wagavulin · 2017-09-18T10:12:56Z

c_glib/README.md

wagavulin · 2017-09-18T10:13:04Z

c_glib/README.md

wagavulin · 2017-09-18T10:13:21Z

c_glib/README.md

wagavulin · 2017-09-18T10:13:27Z

c_glib/README.md

wagavulin · 2017-09-18T10:36:35Z

c_glib/README.md

Thank you for useful advice. However I think such an advanced setting is not necessary for this "common build failures" section. It assumes that Arrow C++ is installed in accordance with cpp/README.md.

…hive on macOS. Fixed format issues: * Use '%' for shell prompt. * Use `console` for console output. * Add empty lines under header lines.

wagavulin · 2017-09-18T13:04:37Z

I have updated based on the comments. Please check.

kou · 2017-09-18T15:03:13Z

Thanks!

kou reviewed Sep 17, 2017

View reviewed changes

kou requested changes Sep 17, 2017

View reviewed changes

asfgit force-pushed the master branch from 40e72f5 to 59b24ba Compare September 17, 2017 17:46

Add "Common build problems" section in the README.md of c_glib

b6c5274

Add some detailed explanation of common build problems especially on macOS because it requires some tweaks.

wagavulin changed the title ~~[ARROW-1464]: [GLib] Add "Common build problems" section into the README.md of c_glib~~ ARROW-1464: [GLib] Add "Common build problems" section into the README.md of c_glib Sep 18, 2017

wagavulin commented Sep 18, 2017

View reviewed changes

Improve format and the explanation of installing/linking autoconf arc…

9b65542

…hive on macOS. Fixed format issues: * Use '%' for shell prompt. * Use `console` for console output. * Add empty lines under header lines.

asfgit closed this in 63e7966 Sep 18, 2017

Conversation

wagavulin commented Sep 16, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wesm commented Sep 17, 2017

Uh oh!

wesm commented Sep 18, 2017

Uh oh!

wagavulin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wagavulin commented Sep 18, 2017

Uh oh!

kou commented Sep 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!