ARROW-1544: [JS] Export Vector types#1103
Closed
trxcllnt wants to merge 5 commits intoapache:masterfrom
graphistry:js-export-vector-typedefs
Closed
ARROW-1544: [JS] Export Vector types#1103trxcllnt wants to merge 5 commits intoapache:masterfrom graphistry:js-export-vector-typedefs
trxcllnt wants to merge 5 commits intoapache:masterfrom
graphistry:js-export-vector-typedefs
Conversation
Member
|
Can you add "ARROW-1544:" to the PR title and rebase on apache/master? I force pushed the branch after the release vote passed |
trxcllnt
changed the title
removes Arrow.internal, since now it's the same as the Arrow export
Contributor
Author
|
@wesm done. I can also squash the commits if you prefer. |
Member
|
No problem. We have a merge tool (https://github.com/apache/arrow/blob/master/dev/merge_arrow_pr.py) that handles squashing and updating JIRA (it uses the PR title to do this) |
wesm
approved these changes
Sep 17, 2017
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
+1, will merge this once the build runs
Member
|
thanks @trxcllnt! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.apache.org/jira/browse/ARROW-1544