ARROW-12759: [C++][Compute] Add ExecNode for group by#10660
Closed
michalursa wants to merge 46 commits intoapache:masterfrom
Closed
ARROW-12759: [C++][Compute] Add ExecNode for group by#10660michalursa wants to merge 46 commits intoapache:masterfrom
michalursa wants to merge 46 commits intoapache:masterfrom
Conversation
bkietz
requested changes
Jul 6, 2021
Member
bkietz
left a comment
bkietz
left a comment
There was a problem hiding this comment.
This looks good so far. We need unit tests, of course
bkietz
force-pushed
the
ARROW-12759-execnode-for-groupby
branch
from
89a37fc to
8b31684
Compare
lidavidm
reviewed
Jul 12, 2021
using per thread copy of data structures and merging them at the end
bkietz
added a commit
that referenced
this pull request
Jul 13, 2021
This is a pretty trivial node but it's needed for completeness and will give bindings a pipeline breaker to experiment with until #10660 merges Closes #10705 from bkietz/13313-Add-ScalarAggregateNode Authored-by: Benjamin Kietzman <[email protected]> Signed-off-by: Benjamin Kietzman <[email protected]>
…rsa/arrow into ARROW-12759-execnode-for-groupby
This reverts commit 92fb25e28e04efabe804dc5a0987aea87edb5a6f.
bkietz
force-pushed
the
ARROW-12759-execnode-for-groupby
branch
from
92fb25e to
3c17e2a
Compare
Member
|
@pitrou care to take a look? |
bkietz
approved these changes
Jul 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding ExecNode for grouped aggregation.