ARROW-12949: [C++] Add starts_with and ends_with#10448
Closed
lidavidm wants to merge 6 commits intoapache:masterfrom
Closed
ARROW-12949: [C++] Add starts_with and ends_with#10448lidavidm wants to merge 6 commits intoapache:masterfrom
lidavidm wants to merge 6 commits intoapache:masterfrom
Conversation
cyb70289
reviewed
Jun 4, 2021
Contributor
There was a problem hiding this comment.
Not sure what this comment means. Looks there's no template around.
Member
Author
There was a problem hiding this comment.
I mean L612-L653 below which are partial template specializations that convert a case-insensitive prefix/suffix match into an equivalent regex (to avoid having to do Unicode case folding ourselves): https://github.com/apache/arrow/pull/10448/files#diff-eb8300bc4dea7d1c46b2576b7dbd8e42b927ab7d42c031f4aecae892a72ee244R612-R653
pitrou
requested changes
Jun 7, 2021
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Thank you. Can you also update docs/source/cpp/compute.rst?
pitrou
approved these changes
Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a simple starts_with and ends_with.
Also, now match_like can optimize some patterns into prefix/suffix matches. This also fixes a bug (which I believe is also present in Apache Impala) where some LIKE patterns are mistakenly optimized into suffix or substring matches.