ARROW-12859: [C++] Add ScalarFromJSON for testing#10386
Closed
lidavidm wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-12859: [C++] Add ScalarFromJSON for testing#10386lidavidm wants to merge 2 commits intoapache:masterfrom
lidavidm wants to merge 2 commits intoapache:masterfrom
Conversation
nirandaperera
approved these changes
May 24, 2021
bkietz
changed the title
bkietz
reviewed
May 25, 2021
cpp/src/arrow/testing/gtest_util.cc
Outdated
Member
There was a problem hiding this comment.
This approach might be worthwhile for consistency's sake, but we could also use Scalar::CastTo
bkietz
approved these changes
May 28, 2021
Member
|
Is there anything left to do here? |
Member
Author
I don't think so unless we really want to use Scalar::CastTo here. |
Member
|
Can you explain the Also, I notice this isn't actually tested? Perhaps add a test alongside those for |
Member
Author
|
For CastTo: I think it was actually the Cast kernel (string->type cast). I added some basic tests. I don't think there's a good way to hit the DCHECK because that would imply a JSON value converter appended two array values for a single JSON value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.