ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark#10346
ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark#10346jorisvandenbossche wants to merge 1 commit intoapache:masterfrom
Conversation
|
This begs the question if we should have a "minimal build" for python as well that turns the tests, otherwise we are to keep forget adding such markers (although in this case if that minimal build didn't include pandas, we still wouldn't have watched that error) |
|
I think it'd make sense for a minimal build to still include Pandas, since it doesn't change anything about the build itself, and would enable more tests, right? |
|
Sounds like a good idea to me. |
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
LGTM. Looks like Homebrew is having some trouble today.
|
Should this also get cherry-picked into 4.0.1? |
|
While it's not essential, it shouldn't cause any trouble. Added to 4.0.1 jira version. |
Yes, indeed, that doesn't impact the build. Having no pandas installed is also a case to test, but we actually do have a "no-pandas" build, so that is already covered. |
…set mark Closes #10346 from jorisvandenbossche/ARROW-12806 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: David Li <[email protected]>
3 participants
No description provided.