ARROW-12603: [C++][Dataset] Backport fix for specifying CSV column types#10344
Merged
kszucs merged 2 commits intoapache:maint-4.0.xfrom May 17, 2021
Merged
ARROW-12603: [C++][Dataset] Backport fix for specifying CSV column types#10344kszucs merged 2 commits intoapache:maint-4.0.xfrom
kszucs merged 2 commits intoapache:maint-4.0.xfrom
Conversation
Member
|
Thanks @lidavidm for the backport! Could we cover this with a minimal test case? |
Member
Author
|
I've added a quick test case. |
kszucs
reviewed
May 17, 2021
| int64_t row_count = 0; | ||
| for (auto maybe_batch : Batches(fragment.get())) { | ||
| ASSERT_OK_AND_ASSIGN(auto batch, maybe_batch); | ||
| row_count += batch->num_rows(); |
Member
There was a problem hiding this comment.
I assume it was failing previously since you don't check the columns.
Member
Author
There was a problem hiding this comment.
Ah yes, without the patch, this will fail before it gets here because it will use the auto-inferred type and try to read the string column as a float64 column.
Member
|
CI failures:
I'm going ahead and merge this. |
Member
|
FTR that R warning will go away when you bump the versions to 4.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports the relevant part of ARROW-12500 into the 4.0.1 branch.
While ARROW-12500 cherry-picks cleanly, it doesn't build since it depends on prior changes - this just includes the actual fix and not the larger refactoring that was the focus of the patch.