ARROW-12769: [Python] Fix slicing array with "negative" length (start > stop)#10341
Closed
jorisvandenbossche wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-12769: [Python] Fix slicing array with "negative" length (start > stop)#10341jorisvandenbossche wants to merge 1 commit intoapache:masterfrom
jorisvandenbossche wants to merge 1 commit intoapache:masterfrom
Conversation
lidavidm
approved these changes
May 17, 2021
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
LGTM. Travis looks like a flake.
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
May 17, 2021
… > stop) When the normalized slice has a start > stop, we were creating invalid arrays with a negative length (which then errors on subsequent operations) Closes apache#10341 from jorisvandenbossche/ARROW-12769 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: David Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the normalized slice has a start > stop, we were creating invalid arrays with a negative length (which then errors on subsequent operations)