ARROW-12578: [JS] Remove Buffer in favor of TextEncoder API to support bundlers such as Rollup#10332
Closed
domoritz wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-12578: [JS] Remove Buffer in favor of TextEncoder API to support bundlers such as Rollup#10332domoritz wants to merge 2 commits intoapache:masterfrom
domoritz wants to merge 2 commits intoapache:masterfrom
Conversation
trxcllnt
approved these changes
May 15, 2021
Member
Author
|
@kou can we add this to the 4.0.1 release since it fixes build issues (https://issues.apache.org/jira/browse/ARROW-12734)? |
domoritz
force-pushed
the
remove-buffer-js
branch
from
4a8e486 to
d819265
Compare
Contributor
|
@domoritz |
Member
|
@domoritz Sure. Bug fixes without API breaking is suitable for a patch release in Semantic Versioning context. Could you update the pull request description before we merge this? We use the pull request description as commit message on merge. |
domoritz
changed the title
Member
Author
|
Excellent. I updated the title. Does it look good to you? |
Member
|
Thanks. I changed I'll merge this. |
Member
Author
|
Great, thank you. |
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
May 17, 2021
…t bundlers such as Rollup Bundlers such as Rollup do not recognize the `_Buffer` import, which breaks their builds. This change resolves this issue by removing Buffer in favor of `TextEncoder`. Note that change incurs a performance penalty on Node as `Buffer` is often faster. Co-authored-by: Adam Lippai <[email protected]> Co-authored-by: Paul Taylor <[email protected]> Closes apache#10332 from domoritz/remove-buffer-js Authored-by: Dominik Moritz <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundlers such as Rollup do not recognize the
_Bufferimport, which breaks their builds. This change resolves this issue by removing Buffer in favor ofTextEncoder. Note that change incurs a performance penalty on Node asBufferis often faster.Co-authored-by: Adam Lippai [email protected]
Co-authored-by: Paul Taylor [email protected]