ARROW-12185: [R] Bindings for any, all#10032
ARROW-12185: [R] Bindings for any, all#10032thisisnic wants to merge 6 commits intoapache:masterfrom
Conversation
| array_data <- Array$create(data) | ||
|
|
||
| expect_equal(as.vector(any(array_data > 5)), any(data > 5)) | ||
| expect_equal(as.vector(any(array_data < 1)), any(data < 1)) | ||
| expect_equal(as.vector(any(array_data < 1, na.rm = TRUE)), any(data < 1, na.rm = TRUE)) |
There was a problem hiding this comment.
These tests could be simplified by using the helper function expect_vector_equal() (which is defined in helper-expectation.R). E.g.:
| array_data <- Array$create(data) | |
| expect_equal(as.vector(any(array_data > 5)), any(data > 5)) | |
| expect_equal(as.vector(any(array_data < 1)), any(data < 1)) | |
| expect_equal(as.vector(any(array_data < 1, na.rm = TRUE)), any(data < 1, na.rm = TRUE)) | |
| expect_vector_equal(any(input > 5), data) | |
| expect_vector_equal(any(input < 1), data) | |
| expect_vector_equal(any(input < 1, na.rm = TRUE), data) |
There was a problem hiding this comment.
Note that expect_vector_equal() tests both Array and ChunkedArray so you'll be able to reduce the number of tests used here
|
@thisisnic it looks like when you ran |
thisisnic
force-pushed
the
ARROW-12185-any_all
branch
from
6f81a57 to
defeac1
Compare
thisisnic
force-pushed
the
ARROW-12185-any_all
branch
from
defeac1 to
12cb6cb
Compare
Fixed now! |
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
Looks good! I'm going to add some inline comments to explain the three-valued logic (as well as tag @rok about doing it correctly in C++), then merge.
5 participants
No description provided.