-
Notifications
You must be signed in to change notification settings - Fork 4k
Closed
Description
Describe the enhancement requested
During review of #46180, it came up that Arrow C++ has two StringBuilders:
- The public builder for utf8() arrays, https://github.com/apache/arrow/blob/main/cpp/src/arrow/array/builder_binary.h#L424 (class)
- A helper in https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/string_builder.h (function)
We should,
- Move StringBuilder (2) in cpp/src/arrow/util/string_builder.h from
arrow::utiltoarrow::internalto make its intended use more clear - Rename
arrow/util/string_builder.{h,c}andarrow::util::StringBuilderto something else to avoid confusing humans and computers
No changes would be made to the official Arrow StringBuilder class.
Component(s)
C++
Reactions are currently unavailable