Skip to content

[C++] Potential buffer overflow when CSV line contains too many columns #45497

Closed

Description

@pitrou

Describe the bug, including details regarding any error messages, version, and platform.

This snippet only has a debug-mode check, but the condition might fail if the CSV line currently parsed has more than num_cols columns.

void PushValue(ParsedValueDesc v) {
DCHECK_LT(values_size_, values_capacity_);
values_[values_size_++] = v;
}

Component(s)

C++

Activity

  1. self-assigned this
    on Feb 11, 2025
  2. pitrou commented on Feb 12, 2025

    @pitrou
    MemberAuthor

    Issue resolved by pull request 45498
    #45498

  3. added this to the 20.0.0 milestone on Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions