Skip to content

[C++] Return references from DictionaryArray accessor methods #35437

@benibus

Description

@benibus

Describe the enhancement requested

Several of the DictionaryArray accessor methods (dictionary() and indices()) currently return a std::shared_ptr<Arrray by value. From looking at the implementation, these underlying arrays are owned by the class so it seems possible to return them as a const std::shared_ptr<Array>& instead - keeping with general conventions and reducing potential gotchas.

Component(s)

C++

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions