Skip to content

[Java] VectorValueComparator should skip the null test for NonNullable FieldTypes types #14844

@markjschreiber

Description

@markjschreiber

Describe the enhancement requested

I recently ran a profiler on a simple implementation of a sort and noticed that the VectorValueComparator spends quite a lot of time checking the values to be compared for null values. In this case I had already declared the FieldType to be notNullable. Unless I am misunderstanding something, the values cannot be null so the comparator is making unnecessary and expensive comparisons.

As a test I made a comparator that skips the null tests and runs ~12% faster as a result. Based on this I think the VectorValueComparator should skip the null test for NonNullable FieldTypes.

I'd be happy to contribute a change to do this if you think it would be reasonable.

Component(s)

Java

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions