Skip to content

Commit f93ba4d

Browse files
authored
MINOR: [C++] Fix StringFormatter type error in localfs_benchmark (#13932)
since size_t is passed as the first argument to the StringFormatter, it needs to be templated with Int64Type instead of Int32Type Lead-authored-by: Aldrin M <[email protected]> Co-authored-by: Aldrin Montana <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
1 parent d53bce2 commit f93ba4d

1 file changed

Lines changed: 4 additions & 12 deletions

File tree

‎cpp/src/arrow/filesystem/localfs_benchmark.cc‎

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
#include "arrow/testing/gtest_util.h"
2828
#include "arrow/testing/random.h"
2929
#include "arrow/util/async_generator.h"
30-
#include "arrow/util/formatting.h"
3130
#include "arrow/util/io_util.h"
3231
#include "arrow/util/make_unique.h"
3332
#include "arrow/util/string_view.h"
@@ -66,13 +65,9 @@ class LocalFSFixture : public benchmark::Fixture {
6665
arrow::internal::PlatformFilename cur_root_dir) {
6766
ASSERT_OK(arrow::internal::CreateDir(cur_root_dir));
6867

69-
arrow::internal::StringFormatter<Int32Type> format;
7068
for (size_t i = 0; i < num_files_; ++i) {
71-
std::string fname = "file_";
72-
format(i, [&fname](util::string_view formatted) {
73-
fname.append(formatted.data(), formatted.size());
74-
});
75-
ASSERT_OK_AND_ASSIGN(auto path, cur_root_dir.Join(std::move(fname)));
69+
ASSERT_OK_AND_ASSIGN(auto path,
70+
cur_root_dir.Join(std::string{"file_" + std::to_string(i)}));
7671
ASSERT_OK(MakeEmptyFile(path.ToString()));
7772
}
7873

@@ -81,11 +76,8 @@ class LocalFSFixture : public benchmark::Fixture {
8176
}
8277

8378
for (size_t i = 0; i < num_dirs_; ++i) {
84-
std::string dirname = "dir_";
85-
format(i, [&dirname](util::string_view formatted) {
86-
dirname.append(formatted.data(), formatted.size());
87-
});
88-
ASSERT_OK_AND_ASSIGN(auto path, cur_root_dir.Join(std::move(dirname)));
79+
ASSERT_OK_AND_ASSIGN(auto path,
80+
cur_root_dir.Join(std::string{"dir_" + std::to_string(i)}));
8981
InitializeDatasetStructure(cur_nesting_level + 1, std::move(path));
9082
}
9183
}

0 commit comments

Comments
 (0)