Skip to content

Commit dc2c5c6

Browse files
authored
MINOR: [C++] Remove misleading comment on FileKeyUnwrapper constructor (#40808)
### Rationale for this change I added this comment in #34181, but from the discussion in #40732 (comment), I realised this comment was incorrect. The extra overload appears to just be a convenience as a `FileKeyMaterialStore` is already constructed in `KeyToolkit::RotateMasterKeys`, but the store isn't actually used by the `FileKeyUnwrapper` in that method, as only `FileKeyUnwrapper::GetDataEncryptionKey` is called, which bypasses the store. `RotateMasterKeys` does however rely on the `temp_key_material_store` passed to the `FileKeyWrapper` being used, which is possibly where this confusion came from. ### What changes are included in this PR? Removes an incorrect statement from a C++ header comment. ### Are these changes tested? NA ### Are there any user-facing changes? No Authored-by: Adam Reeve <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
1 parent 83dc0a9 commit dc2c5c6

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

‎cpp/src/parquet/encryption/file_key_unwrapper.h‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,7 @@ class PARQUET_EXPORT FileKeyUnwrapper : public DecryptionKeyRetriever {
5757

5858
/// Constructor overload that takes a raw pointer to the KeyToolkit and
5959
/// accepts an existing key_material_store rather than using
60-
/// the file path and file system to create one when needed. This is useful for key
61-
/// rotation to allow accessing the key material store after it is used.
60+
/// the file path and file system to create one when needed.
6261
FileKeyUnwrapper(KeyToolkit* key_toolkit,
6362
const KmsConnectionConfig& kms_connection_config,
6463
double cache_lifetime_seconds,

0 commit comments

Comments
 (0)