You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b44e1d7
Browse filesBrowse the repository at this point in the historyBrowse files
GH-55596: [Python][Annotations] Add runtime docstrings to the type stubs with docstring-adder
Squash the stub-only pyarrow.__lib package into lib.pyi, with a section
per .pxi file, since pyarrow.lib is a single extension module built from
the .pxi files it includes. The per-file __all__ lists go away, and so
does the aliasing of pyarrow.__lib modules to pyarrow.lib in
run_stubtest.py.
Replace the libcst codemod in update_stub_docstrings.py with
docstring-adder (https://github.com/astral-sh/docstring-adder). The script
still assembles an importable pyarrow from the source and install trees,
then runs docstring-adder on the installed stubs and checks that lib.pyi
got docstrings.
Build the Cython modules with embedsignature.format=clinic, so that the
embedded signatures go to __text_signature__ instead of the first lines of
__doc__ and don't end up in the docstrings of the stubs.
Install the stubs into wheels again and add the docstrings in the wheel
builds (PYARROW_REQUIRE_STUB_DOCSTRINGS=ON). py.typed stays excluded from
wheels until the stubs are complete (GH-49831).
Check the stubs in each built wheel against the modules in the same wheel
with stubtest (run_stubtest.py --wheel) in the wheel build scripts. The
wheel builds don't install the pandas and scipy stubs, so mypy treats
those modules as Any when their stubs are missing.
The wheel content validation checks again that the wheels contain the
stubs of pyarrow-stubs/ with docstrings, and still that they don't
contain py.typed.
libcst is no longer a build requirement. docstring-adder isn't on PyPI, so
requirements-wheel-build.txt pins it to a commit.
0 commit comments