Skip to content

Commit 937f62c

Browse files
committed
GH-48743: [C++] Re-enable timezone tests on Windows GCC
Remove all six Windows GCC timezone test skips now that upstream has fixed libstdc++ bug 116110. Run the tests without version gates first so any remaining toolchain-specific failures can be identified by CI. Leave all test expectations, backend selection, and the Windows libc++ fallback unchanged. Signed-off-by: Rok Mihevc <[email protected]>
1 parent f95b001 commit 937f62c

2 files changed

Lines changed: 0 additions & 30 deletions

File tree

‎cpp/src/arrow/compute/kernels/scalar_cast_test.cc‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2570,11 +2570,6 @@ TEST(Cast, TimestampToTime) {
25702570
}
25712571

25722572
TEST_F(CastTimezone, ZonedTimestampToTime) {
2573-
// TODO(GH-48743): GCC libstdc++ has a bug with DST transitions
2574-
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110
2575-
#if defined(_WIN32) && defined(__GNUC__) && !defined(__clang__)
2576-
GTEST_SKIP() << "Test triggers GCC libstdc++ bug (GH-48743).";
2577-
#endif
25782573
CheckCast(ArrayFromJSON(timestamp(TimeUnit::NANO, "Pacific/Marquesas"), kTimestampJson),
25792574
ArrayFromJSON(time64(TimeUnit::NANO), R"([
25802575
52259123456789, 50003999999999, 56480001001001, 65000000000000,

‎cpp/src/arrow/compute/kernels/scalar_temporal_test.cc‎

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -708,11 +708,6 @@ TEST_F(ScalarTemporalTest, TestIsLeapYear) {
708708
}
709709

710710
TEST_F(ScalarTemporalTest, TestZoned1) {
711-
// TODO(GH-48743): GCC libstdc++ has a bug with DST transitions
712-
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110
713-
#if defined(_WIN32) && defined(__GNUC__) && !defined(__clang__)
714-
GTEST_SKIP() << "Test triggers GCC libstdc++ bug (GH-48743).";
715-
#endif
716711
std::vector<std::string> timezones = {"Pacific/Marquesas", "-09:30"};
717712
for (const auto& timezone : timezones) {
718713
auto unit = timestamp(TimeUnit::NANO, timezone);
@@ -811,11 +806,6 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
811806
}
812807

813808
TEST_F(ScalarTemporalTest, TestZoned2) {
814-
// TODO(GH-48743): GCC libstdc++ has a bug with DST transitions
815-
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110
816-
#if defined(_WIN32) && defined(__GNUC__) && !defined(__clang__)
817-
GTEST_SKIP() << "Test triggers GCC libstdc++ bug (GH-48743).";
818-
#endif
819809
for (auto u : TimeUnit::values()) {
820810
auto unit = timestamp(u, "Australia/Broken_Hill");
821811
auto month = "[1, 3, 1, 5, 1, 12, 12, 12, 1, 1, 1, 1, 12, 12, 12, 1, null]";
@@ -2777,11 +2767,6 @@ TEST_F(ScalarTemporalTestMultipleSinceGreaterUnit, CeilUTC) {
27772767
}
27782768

27792769
TEST_F(ScalarTemporalTestMultipleSinceGreaterUnit, CeilZoned) {
2780-
// TODO(GH-48743): GCC libstdc++ has a bug with DST transitions
2781-
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110
2782-
#if defined(_WIN32) && defined(__GNUC__) && !defined(__clang__)
2783-
GTEST_SKIP() << "Test triggers GCC libstdc++ bug (GH-48743).";
2784-
#endif
27852770
std::string op = "ceil_temporal";
27862771

27872772
// Data for tests below was generated via lubridate with the exception
@@ -3172,11 +3157,6 @@ TEST_F(ScalarTemporalTestMultipleSinceGreaterUnit, FloorUTC) {
31723157
}
31733158

31743159
TEST_F(ScalarTemporalTestMultipleSinceGreaterUnit, FloorZoned) {
3175-
// TODO(GH-48743): GCC libstdc++ has a bug with DST transitions
3176-
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110
3177-
#if defined(_WIN32) && defined(__GNUC__) && !defined(__clang__)
3178-
GTEST_SKIP() << "Test triggers GCC libstdc++ bug (GH-48743).";
3179-
#endif
31803160
std::string op = "floor_temporal";
31813161

31823162
// Data for tests below was generated via lubridate with the exception
@@ -3610,11 +3590,6 @@ TEST_F(ScalarTemporalTestMultipleSinceGreaterUnit, RoundUTC) {
36103590
}
36113591

36123592
TEST_F(ScalarTemporalTestMultipleSinceGreaterUnit, RoundZoned) {
3613-
// TODO(GH-48743): GCC libstdc++ has a bug with DST transitions
3614-
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110
3615-
#if defined(_WIN32) && defined(__GNUC__) && !defined(__clang__)
3616-
GTEST_SKIP() << "Test triggers GCC libstdc++ bug (GH-48743).";
3617-
#endif
36183593
std::string op = "round_temporal";
36193594

36203595
// Data for tests below was generated via lubridate with the exception

0 commit comments

Comments
 (0)