Repository navigation
Commit 84d9c88
authored
### Rationale for this change
Support float16/halffloat type in some functions which are agnostic to the numeric value.
* Includes `replace_with_mask` as requested in #37027
### What changes are included in this PR?
* Added a case to `GenerateTypeAgnosticPrimitive` for `HALF_FLOAT`
* Added `float16` kernels for `if_else`, `case_when`, `coalesce`, and `choose`
* Added `float16` kernels for `replace_with_mask`, `fill_null_forward`, `fill_null_backward`
* Add `HalfFloatType` to the list of types tested for the above functions
### Are these changes tested?
Yes
### Are there any user-facing changes?
Functions listed above now support float16
* GitHub Issue: #37027
Authored-by: Colin Schultz <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
1 parent 8262e42 commit 84d9c88
7 files changed
Lines changed: 30 additions & 9 deletions
File tree
- cpp/src/arrow
- compute/kernels
- testing
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1262 | 1262 | | |
1263 | 1263 | | |
1264 | 1264 | | |
| 1265 | + | |
1265 | 1266 | | |
1266 | 1267 | | |
1267 | 1268 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2870 | 2870 | | |
2871 | 2871 | | |
2872 | 2872 | | |
2873 | | - | |
| 2873 | + | |
2874 | 2874 | | |
2875 | 2875 | | |
2876 | 2876 | | |
| |||
2886 | 2886 | | |
2887 | 2887 | | |
2888 | 2888 | | |
2889 | | - | |
| 2889 | + | |
2890 | 2890 | | |
2891 | 2891 | | |
2892 | 2892 | | |
| |||
2902 | 2902 | | |
2903 | 2903 | | |
2904 | 2904 | | |
2905 | | - | |
| 2905 | + | |
2906 | 2906 | | |
2907 | 2907 | | |
2908 | 2908 | | |
| |||
2920 | 2920 | | |
2921 | 2921 | | |
2922 | 2922 | | |
2923 | | - | |
| 2923 | + | |
2924 | 2924 | | |
2925 | 2925 | | |
2926 | 2926 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
84 | | - | |
85 | | - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
843 | 843 | | |
844 | 844 | | |
845 | 845 | | |
| 846 | + | |
846 | 847 | | |
847 | 848 | | |
848 | 849 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
233 | 233 | | |
234 | 234 | | |
235 | 235 | | |
236 | | - | |
237 | | - | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
238 | 239 | | |
239 | 240 | | |
240 | 241 | | |
| |||
1490 | 1491 | | |
1491 | 1492 | | |
1492 | 1493 | | |
| 1494 | + | |
1493 | 1495 | | |
1494 | 1496 | | |
1495 | 1497 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
95 | 100 | | |
96 | 101 | | |
97 | 102 | | |
| |||
148 | 153 | | |
149 | 154 | | |
150 | 155 | | |
| 156 | + | |
| 157 | + | |
151 | 158 | | |
152 | 159 | | |
153 | 160 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
109 | 117 | | |
110 | 118 | | |
111 | 119 | | |
| |||
151 | 159 | | |
152 | 160 | | |
153 | 161 | | |
| 162 | + | |
| 163 | + | |
154 | 164 | | |
155 | 165 | | |
156 | 166 | | |
| |||
0 commit comments