Skip to content

Commit 6240eae

Browse files
branczMatthew Topol
authored andcommitted
ARROW-16193: [Go] Replace CPU discovery package with golang.org/x/sys/cpu module
The package deleted in this commit is an outdated copy of a package that used to be an internal package in the Go standard library, but since then it has been moved to the publicly accessible golang.org/x/sys module. Since that module is already used, this commit does not even add a new dependency. Other than removing unnecessary code it also makes CPU feature discovery more consistent with other projects in the Go ecosystem. For example it is no longer necessary to pass an environment variable to enable usage of ARM64 NEON SIMD instructions. Closes #12764 from brancz/go-cpu-discovery Authored-by: Frederic Branczyk <[email protected]> Signed-off-by: Matthew Topol <[email protected]>
1 parent 667d427 commit 6240eae

11 files changed

Lines changed: 4 additions & 357 deletions

File tree

‎go/arrow/internal/cpu/README.md‎

Lines changed: 0 additions & 42 deletions
This file was deleted.

‎go/arrow/internal/cpu/cpu.go‎

Lines changed: 0 additions & 77 deletions
This file was deleted.

‎go/arrow/internal/cpu/cpu_arm64.go‎

Lines changed: 0 additions & 37 deletions
This file was deleted.

‎go/arrow/internal/cpu/cpu_s390x.go‎

Lines changed: 0 additions & 7 deletions
This file was deleted.

‎go/arrow/internal/cpu/cpu_test.go‎

Lines changed: 0 additions & 51 deletions
This file was deleted.

‎go/arrow/internal/cpu/cpu_x86.go‎

Lines changed: 0 additions & 107 deletions
This file was deleted.

‎go/arrow/internal/cpu/cpu_x86.s‎

Lines changed: 0 additions & 32 deletions
This file was deleted.

‎go/arrow/math/math_amd64.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
package math
2020

2121
import (
22-
"github.com/apache/arrow/go/v8/arrow/internal/cpu"
22+
"golang.org/x/sys/cpu"
2323
)
2424

2525
func init() {

‎go/arrow/math/math_arm64.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
package math
2020

2121
import (
22-
"github.com/apache/arrow/go/v8/arrow/internal/cpu"
22+
"golang.org/x/sys/cpu"
2323
)
2424

2525
func init() {

‎go/arrow/memory/memory_amd64.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
package memory
2020

2121
import (
22-
"github.com/apache/arrow/go/v8/arrow/internal/cpu"
22+
"golang.org/x/sys/cpu"
2323
)
2424

2525
func init() {

0 commit comments

Comments
 (0)