Add emit trailing point tests

anthonylouisbsb · anthonylouisbsb · commit 302139c78e29 · 2021-04-13T16:20:47.000-03:00
diff --git a/cpp/src/arrow/vendored/double-conversion/double-conversion.cc b/cpp/src/arrow/vendored/double-conversion/double-conversion.cc
@@ -84,7 +84,15 @@ void DoubleToStringConverter::CreateExponentialRepresentation(
     StringBuilder* result_builder) const {
   ASSERT(length != 0);
   result_builder->AddCharacter(decimal_digits[0]);
-  if (length != 1) {
+
+  if(length == 1){
+    if ((flags_ & EMIT_TRAILING_DECIMAL_POINT) != 0) {
+      result_builder->AddCharacter('.');
+    }
+    if ((flags_ & EMIT_TRAILING_ZERO_AFTER_POINT) != 0) {
+      result_builder->AddCharacter('0');
+    }
+  } else {
     result_builder->AddCharacter('.');
     result_builder->AddSubstring(&decimal_digits[1], length-1);
   }
diff --git a/cpp/src/gandiva/gdv_function_stubs_test.cc b/cpp/src/gandiva/gdv_function_stubs_test.cc
@@ -234,7 +234,7 @@ TEST(TestGdvFnStubs, TestCastVARCHARFromFloat) {
   EXPECT_FALSE(ctx.has_error());
 
   out_str = gdv_fn_castVARCHAR_float32_int64(ctx_ptr, 0.00001f, 100, &out_len);
-  EXPECT_EQ(std::string(out_str, out_len), "1E-5");
+  EXPECT_EQ(std::string(out_str, out_len), "1.0E-5");
   EXPECT_FALSE(ctx.has_error());
 
   out_str = gdv_fn_castVARCHAR_float32_int64(ctx_ptr, 0.00099999f, 100, &out_len);
@@ -245,6 +245,10 @@ TEST(TestGdvFnStubs, TestCastVARCHARFromFloat) {
   EXPECT_EQ(std::string(out_str, out_len), "0.0");
   EXPECT_FALSE(ctx.has_error());
 
+  out_str = gdv_fn_castVARCHAR_float32_int64(ctx_ptr, 10.00000f, 100, &out_len);
+  EXPECT_EQ(std::string(out_str, out_len), "10.0");
+  EXPECT_FALSE(ctx.has_error());
+
   // test with required length less than actual buffer length
   out_str = gdv_fn_castVARCHAR_float32_int64(ctx_ptr, 1.2345f, 3, &out_len);
   EXPECT_EQ(std::string(out_str, out_len), "1.2");
@@ -265,7 +269,7 @@ TEST(TestGdvFnStubs, TestCastVARCHARFromDouble) {
   EXPECT_FALSE(ctx.has_error());
 
   out_str = gdv_fn_castVARCHAR_float64_int64(ctx_ptr, 0.00001, 100, &out_len);
-  EXPECT_EQ(std::string(out_str, out_len), "1E-5");
+  EXPECT_EQ(std::string(out_str, out_len), "1.0E-5");
   EXPECT_FALSE(ctx.has_error());
 
   out_str = gdv_fn_castVARCHAR_float32_int64(ctx_ptr, 0.00099999f, 100, &out_len);
@@ -276,6 +280,10 @@ TEST(TestGdvFnStubs, TestCastVARCHARFromDouble) {
   EXPECT_EQ(std::string(out_str, out_len), "0.0");
   EXPECT_FALSE(ctx.has_error());
 
+  out_str = gdv_fn_castVARCHAR_float64_int64(ctx_ptr, 10.0000000000, 100, &out_len);
+  EXPECT_EQ(std::string(out_str, out_len), "10.0");
+  EXPECT_FALSE(ctx.has_error());
+
   // test with required length less than actual buffer length
   out_str = gdv_fn_castVARCHAR_float64_int64(ctx_ptr, 1.2345, 3, &out_len);
   EXPECT_EQ(std::string(out_str, out_len), "1.2");
