Skip to content

Commit 0bd8def

Browse files
raulcdraulcd
authored
GH-51343: [C++][CI][Packaging] Disable Precompile Headers on simdjson to avoid not reproducible artifacts (#51355)
### Rationale for this change Reproducible builds are currently failing since simdjson changes were merged. ### What changes are included in this PR? Disable Precompiled Headers on simdjson to avoid failing reproducible builds. ### Are these changes tested? Yes on CI ### Are there any user-facing changes? No ### Was AI used for this PR? In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR. **PR code and description written by:** - [x] Human - [ ] AI **Reviewed before submission by:** - [x] Human - [ ] AI - [ ] Not reviewed Note: AI was used to diagnose the reproducible build failure otuput from diffoscope, failure on this gist: https://gist.github.com/raulcd/b2961cc053ae2d3033742e790d474b5b * GitHub Issue: #51343 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
1 parent 8b617fe commit 0bd8def

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

‎cpp/cmake_modules/ThirdpartyToolchain.cmake‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2834,6 +2834,11 @@ function(build_simdjson)
28342834

28352835
prepare_fetchcontent()
28362836

2837+
# simdjson enables precompiled headers unconditionally.
2838+
# Recompiling simdjson.cpp against it produces differing artifacts
2839+
# Disable precompiled headers to avoid reproducible build failures.
2840+
set(CMAKE_DISABLE_PRECOMPILE_HEADERS ON)
2841+
28372842
fetchcontent_makeavailable(simdjson)
28382843

28392844
target_compile_definitions(simdjson PUBLIC SIMDJSON_EXCEPTIONS=0)

0 commit comments

Comments
 (0)