Skip to content

feat: Add automatic key generation in docker compose#548

Closed
Revolyssup wants to merge 3 commits into
apache:masterfrom
Revolyssup:revolyssup/autogeneratekey
Closed

feat: Add automatic key generation in docker compose#548
Revolyssup wants to merge 3 commits into
apache:masterfrom
Revolyssup:revolyssup/autogeneratekey

Conversation

@Revolyssup

Copy link
Copy Markdown
Contributor

This PR is part of the proposal which removes hardcoding of sensitive API keys by autogenerating them at either application level(APISIX) or deployment level(like docker.)

Comment thread compose/modify_config.sh
cat /tmp/temp_config.yaml > /config.yaml

# Remove the temporary file
rm /tmp/temp_config.yaml

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can combine those command into one command.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directly pushing to config.yaml was giving some errors so i created a temp file

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-03-30 at 3 57 05 PM

@github-actions

github-actions Bot commented Jun 9, 2024

Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Jun 9, 2024
@github-actions

github-actions Bot commented Jul 8, 2024

Copy link
Copy Markdown

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Jul 8, 2024
@Revolyssup Revolyssup reopened this Jul 8, 2024
@github-actions

github-actions Bot commented Aug 6, 2024

Copy link
Copy Markdown

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants