Skip to content

feat: make it support rewrite request body in external plugins#9990

Merged
juststillthinking merged 3 commits into
apache:masterfrom
kldcty:master
Sep 22, 2023
Merged

feat: make it support rewrite request body in external plugins#9990
juststillthinking merged 3 commits into
apache:masterfrom
kldcty:master

Conversation

@kldcty

@kldcty kldcty commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Description

Resubmit for #9864

Please update ext-plugin-proto first. api7/ext-plugin-proto#35

To make it be able to rewrite the request body in external plugins.

Add test according to https://github.com/jiangfucheng 's suggest.

Please help to correct it if something wrong, because i don't know how the test is working.

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@moonming

moonming commented Aug 11, 2023

Copy link
Copy Markdown
Member

@monkeyDluffy6017 please take a look

@Revolyssup

Revolyssup commented Aug 11, 2023

Copy link
Copy Markdown
Contributor

This PR depends on api7/ext-plugin-proto#35

@juststillthinking juststillthinking added the wait for update wait for the author's response in this issue/PR label Aug 14, 2023
@juststillthinking

juststillthinking commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

@jiangfucheng Could you help to review this?

@jiangfucheng jiangfucheng self-assigned this Aug 14, 2023
@jiangfucheng

jiangfucheng commented Aug 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@monkeyDluffy6017 api7/ext-plugin-proto#35 This PR need to be merged first and we need to release a new version for ext-plugin-proto

@jiangfucheng

jiangfucheng commented Sep 7, 2023

Copy link
Copy Markdown
Member

@monkeyDluffy6017 @Sn0rt Hi, could you help review api7/ext-plugin-proto#35? I will take over the current PR after api7/ext-plugin-proto#35 has been merged

@juststillthinking

juststillthinking commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

@jiangfucheng the api7/ext-plugin-proto#35 is merged, please go on

@Revolyssup

Revolyssup commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

@jiangfucheng Will you take this forward?

@jiangfucheng

jiangfucheng commented Sep 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@jiangfucheng Will you take this forward?

ext-plugin-proto need to release a new version, and then we can use it in APISIX. I'm not a member of api7 org, so I need to wait for the maintainer of api7 to release the new version.

@Revolyssup Revolyssup mentioned this pull request Sep 18, 2023
Merged
@Revolyssup Revolyssup removed the wait for update wait for the author's response in this issue/PR label Sep 18, 2023
@Revolyssup Revolyssup self-assigned this Sep 18, 2023
@Revolyssup

Revolyssup commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

@jiangfucheng release has been made

@jiangfucheng

jiangfucheng commented Sep 22, 2023

Copy link
Copy Markdown
Member

@monkeyDluffy6017 Hi, please take a look, thanks.

@jiangfucheng

jiangfucheng commented Sep 22, 2023

Copy link
Copy Markdown
Member

I will try to support this feature in apisix-go-plugin-runner after this PR merged.

@juststillthinking
juststillthinking merged commit 88da2ec into apache:master Sep 22, 2023
@moonming moonming mentioned this pull request Oct 9, 2023
Closed
5 tasks
@zxyao145

zxyao145 commented Oct 16, 2023

Copy link
Copy Markdown

Hi, which version is accessible? Is 3.2.x okay?

@juststillthinking

juststillthinking commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

@zxyao145 This feature is integrated into v3.6.0, you can check the changelog: https://github.com/apache/apisix/blob/release/3.6/CHANGELOG.md#360

@zxyao145 zxyao145 mentioned this pull request Nov 4, 2023
Closed
@gaoxingliang gaoxingliang mentioned this pull request Nov 20, 2023
Closed
@Baoyuantop Baoyuantop mentioned this pull request Mar 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Revolyssup Revolyssup Revolyssup approved these changes
+1 more reviewer
@juststillthinking juststillthinking juststillthinking approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jiangfucheng jiangfucheng

@Revolyssup Revolyssup

Labels

None yet

Projects

⚡️ Apache APISIX Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kldcty @moonming @Revolyssup @juststillthinking @jiangfucheng @zxyao145