Skip to content

fix(limit-count): X-RateLimit-Reset shouldn't be set to 0 after request be rejected#9978

Merged
juststillthinking merged 2 commits into
apache:masterfrom
jiangfucheng:fix_limit_count
Aug 8, 2023
Merged

fix(limit-count): X-RateLimit-Reset shouldn't be set to 0 after request be rejected#9978
juststillthinking merged 2 commits into
apache:masterfrom
jiangfucheng:fix_limit_count

Conversation

@jiangfucheng

Copy link
Copy Markdown
Member

…rejected

Description

Fixes #9964

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@jiangfucheng jiangfucheng changed the title fix: X-RateLimit-Reset shouldn't be set to 0 after request be rejected fix(limit-count): X-RateLimit-Reset shouldn't be set to 0 after request be rejected Aug 6, 2023
@moonming

moonming commented Aug 7, 2023

Copy link
Copy Markdown
Member

Not directly related to this PR, but somewhat related.
Where is the incoming function implemented in https://github.com/apache/apisix/blob/master/apisix/plugins/limit-count/limit-count-local.lua#L67? The standard function does not have the cost parameter.
@shreemaan-abhishek do you know this?

@juststillthinking
juststillthinking merged commit 8f289ba into apache:master Aug 8, 2023
kldcty pushed a commit to kldcty/apisix that referenced this pull request Aug 8, 2023
@jiangfucheng
jiangfucheng deleted the fix_limit_count branch August 12, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: limit count X-RateLimit-Reset is 0

4 participants