fix(nacos): add skipped nil check for "applications" upvalue#9960
Conversation
Signed-off-by: revolyssup <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
ff0d34f
| return nil | ||
| if not applications or not applications[namespace_id] | ||
| or not applications[namespace_id][group_name] then | ||
| return nil |
There was a problem hiding this comment.
four spaces are needed
There was a problem hiding this comment.
if not applications or not applications[namespace_id]
or not applications[namespace_id][group_name]
then
return nil
Signed-off-by: Ashish Tiwari <[email protected]>
|
@Revolyssup please merge the master branch |
done |
|
我有一点疑问:仅仅增加非空判断是否依然不能解决问题。因为在高并发情况下,我从日志上看到: 是否应该异步刷新,增加异步刷新结果、刷新时间和空值次数的控制。 我对lua不太了解,可能会有常识错误。如有问题请不要见怪 I have a question about whether simply adding nonempty judgments still won't solve the problem. Because in the case of high concurrency, I see from the log:
Whether to refresh asynchronously, increase the control of asynchronous refresh result, refresh time, and null times. I don't know much about lua and there may be common sense errors. Please don't be offended if you have any questions |
Description
Fixes #9527 (issue)
After the 5 second wait time, it can be possible that
applicationsupvalue has still not being populated and is nil. So it should be checked.Checklist