Skip to content

feat: support host level dynamic setting of tls protocol version#9903

Merged
juststillthinking merged 14 commits into
apache:masterfrom
AlinsRan:feat/ssl_protocols
Aug 4, 2023
Merged

feat: support host level dynamic setting of tls protocol version#9903
juststillthinking merged 14 commits into
apache:masterfrom
AlinsRan:feat/ssl_protocols

Conversation

@AlinsRan

@AlinsRan AlinsRan commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Description

Fixes #9885

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@AlinsRan
AlinsRan force-pushed the feat/ssl_protocols branch 6 times, most recently from b0db19b to 44a00a3 Compare July 26, 2023 20:19
@AlinsRan
AlinsRan force-pushed the feat/ssl_protocols branch from 44a00a3 to 541ce66 Compare July 28, 2023 01:52
@AlinsRan
AlinsRan marked this pull request as ready for review July 28, 2023 02:19
@AlinsRan
AlinsRan force-pushed the feat/ssl_protocols branch 5 times, most recently from dd8bfd4 to 49773e3 Compare July 31, 2023 15:07
Comment thread apisix/init.lua Outdated
Comment thread apisix/init.lua Outdated
Comment thread apisix/ssl.lua Outdated
Comment thread apisix/ssl.lua Outdated
Comment thread apisix/ssl.lua
Comment thread apisix/ssl/router/radixtree_sni.lua Outdated
Comment thread apisix/ssl/router/radixtree_sni.lua Outdated
Comment thread docs/en/latest/ssl-protocol.md Outdated
Comment thread docs/zh/latest/ssl-protocol.md Outdated
Comment thread docs/en/latest/ssl-protocol.md Outdated
@AlinsRan

AlinsRan commented Aug 1, 2023

Copy link
Copy Markdown
Contributor Author

@kayx23 Please help review the doc.

Comment thread docs/en/latest/ssl-protocol.md Outdated
Comment thread docs/en/latest/ssl-protocol.md Outdated
Comment thread docs/en/latest/ssl-protocol.md Outdated
Comment thread docs/en/latest/ssl-protocol.md Outdated
Comment thread docs/en/latest/ssl-protocol.md Outdated
Comment thread docs/en/latest/ssl-protocol.md Outdated
Comment thread apisix/init.lua
Comment thread docs/en/latest/ssl-protocol.md Outdated
@AlinsRan
AlinsRan requested review from kayx23 and leslie-tsang August 1, 2023 07:47
if not matched_ssl then
return false, "failed to match ssl certificate"
end
local ok, err

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused var ok here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 242 has.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, err = _M.set_cert_and_key(sni, new_ssl_value)

Comment thread apisix/schema_def.lua Outdated
kingluo
kingluo previously approved these changes Aug 2, 2023
Comment thread apisix/init.lua
Comment thread apisix/init.lua Outdated
@juststillthinking juststillthinking added the wait for update wait for the author's response in this issue/PR label Aug 2, 2023
@juststillthinking juststillthinking added approved and removed wait for update wait for the author's response in this issue/PR labels Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Support host level dynamic setting of tls protocol version

5 participants