feat: make it support rewrite request body in external plugins#9864
Closed
kldcty wants to merge 0 commit into
Closed
feat: make it support rewrite request body in external plugins#9864kldcty wants to merge 0 commit into
kldcty wants to merge 0 commit into
Conversation
Member
|
This PR is based on api7/ext-plugin-proto#35, maybe we should wait for the PR to merge and then update the dependency version of |
| local len = rewrite:BodyLength() | ||
| if len > 0 then | ||
| let body = rewrite:BodyAsString() | ||
| ngx.req.set_body_data(body) |
Member
There was a problem hiding this comment.
Suggested change
| ngx.req.set_body_data(body) | |
| ngx.req.read_body() | |
| ngx.req.set_body_data(body) |
We need call ngx.req.read_body() before set_body_data
Member
|
Before this line, we can mock And then, we can add test cases in |
Member
|
We aslo should update the documents. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
make it support rewrite request body.
please update ext-plugin-proto first.
to make it be able to rewrite the request body in external plugins.
i don't have a full development environment for apisix. someone have the full development env can help to add the test code.
Fixes # (issue)
Checklist