Skip to content

feat: support pulling env vars from yaml keys#9855

Merged
juststillthinking merged 11 commits into
apache:masterfrom
shreemaan-abhishek:feat/support-env-var-on-keys
Aug 4, 2023
Merged

feat: support pulling env vars from yaml keys#9855
juststillthinking merged 11 commits into
apache:masterfrom
shreemaan-abhishek:feat/support-env-var-on-keys

Conversation

@shreemaan-abhishek

@shreemaan-abhishek shreemaan-abhishek commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

Description

Fixes #9839

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dreek1337 dreek1337 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a more efficient solution!

@dreek1337 dreek1337 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great solution, I think it will make it easier for people to work in standalone mode

Comment thread apisix/cli/file.lua
Comment thread apisix/cli/file.lua
Comment thread apisix/cli/file.lua
Comment thread apisix/cli/file.lua
@juststillthinking juststillthinking added the wait for update wait for the author's response in this issue/PR label Jul 24, 2023
Comment thread apisix/cli/file.lua Outdated
@juststillthinking juststillthinking added approved and removed wait for update wait for the author's response in this issue/PR labels Aug 2, 2023
@juststillthinking
juststillthinking merged commit d80fc3b into apache:master Aug 4, 2023
kldcty pushed a commit to kldcty/apisix that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Changing the apisix.yaml configuration for Standalone mode

4 participants