fix: loki-logger nil context in batch processor#9850
Merged
Conversation
Signed-off-by: revolyssup <[email protected]>
juststillthinking
added
the
wait for update
Signed-off-by: Ashish Tiwari <[email protected]>
juststillthinking
added
approved
and removed
wait for update
juststillthinking
approved these changes
Jul 19, 2023
Sn0rt
approved these changes
Jul 21, 2023
leslie-tsang
approved these changes
Jul 24, 2023
kldcty
pushed a commit
to kldcty/apisix
that referenced
this pull request
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9848
The nginx variable evaluation currently takes place inside callback function which is executed by batch processor and
ngx.varis not available outside of request phases. This change makes sure that the variables are evaluated in the hot path.Fixes # (issue)
Checklist