refactor: access customized config directly#9846
Conversation
|
More test cases will be added. |
|
@Revolyssup Please help to check this, to see if it works |
| if not ok then | ||
| util.die("failed to backup config, error: ", err) | ||
| if not util.file_exists(customized_config_path) then | ||
| util.die("customized config file not exists, path: " .. customized_config_path) |
There was a problem hiding this comment.
@jiangfucheng Just a note that in my PR here[1], I have moved out all util.Die outside the start function by returning errors.
There was a problem hiding this comment.
In this PR, we don't need to check the result of init() method or other failures in apisix start, we just remove the.config_path file before start is enough.
I can confirm that this issue- #9171 as well as this- #9700 doesn't come up on this PR. |
|
Please fix the code lint |
|
Could you add a test case to cover #9171? |
Added. |
|
@monkeyDluffy6017 Please take a look again, thanks. |
|
Please fix the code lint |
juststillthinking
added
the
wait for update
juststillthinking
added
approved
and removed
wait for update
4 participants
Description
Fixes #9171
Discussion in #9521 (comment)
Checklist