change(ua-restriction): allowlist and denylist can't be enabled at the same time#9841
Merged
Merged
Conversation
jiangfucheng
commented
Jul 15, 2023
juststillthinking
changed the title
juststillthinking
added
the
wait for update
Contributor
|
@jiangfucheng thx your PR, pls take a look at the comments from monkeyDluffy6017 |
|
|
||
|
|
||
|
|
||
| === TEST 18: bypass_missing test, using default, reset conf(part1) |
Contributor
There was a problem hiding this comment.
The bypass_missing should work when allowlist or denylist exists and no user agent, the test case is needed
juststillthinking
approved these changes
Jul 19, 2023
juststillthinking
added
approved
and removed
wait for update
leslie-tsang
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7467
Checklist